Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): cleanup message for input with no config #519

Merged
merged 3 commits into from
Jan 27, 2019
Merged

fix(cli): cleanup message for input with no config #519

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa5d1bc
fix(cli): cleanup message for input with no config
escapedcat Dec 12, 2018
fa0d78d
chore(format): remove linebreaks from output
escapedcat Dec 16, 2018
1e1ab06
refactor(cli): empty results on no-config
escapedcat Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion @commitlint/cli/src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,14 @@ async function main(options) {
);

if (Object.keys(loaded.rules).length === 0) {
let input = '';

if (results.length !== 0) {
const originalInput = results[0].input;
escapedcat marked this conversation as resolved.
Show resolved Hide resolved
input = originalInput;
results.pop();
}

results.push({
valid: false,
errors: [
Expand All @@ -166,7 +174,7 @@ async function main(options) {
}
],
warnings: [],
input: ''
input
});
}

Expand Down
2 changes: 1 addition & 1 deletion @commitlint/format/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function formatInput(result = {}, options = {}) {

const sign = '⧗';
const decoration = enabled ? chalk.gray(sign) : sign;
const commitText = errors.length > 0 ? `\n${input}\n` : input.split('\n')[0];
const commitText = errors.length > 0 ? input : input.split('\n')[0];
escapedcat marked this conversation as resolved.
Show resolved Hide resolved

const decoratedInput = enabled ? chalk.bold(commitText) : commitText;

Expand Down