test: eslint setup #981
Merged
test: eslint setup #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Feb 8, 2020
|
|
||
| // Enable after https://github.com/benmosher/eslint-plugin-import/issues/1650 is fixed | ||
| // Forbid the use of extraneous packages | ||
| // 'import/no-extraneous-dependencies': [ |
There was a problem hiding this comment.
if i manage to somehow make this rule work for this repo, it can replace utils package
|
@marionebl most likely you are going to want to do some adaptations to this config but for now i enabled most of recommended rules, with few exceptions that was reporting errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic eslint setup
Description
Motivation and Context
#970 (comment)
Usage examples
How Has This Been Tested?
Types of changes
Checklist: