-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing tag for ESLint convention #403
Comments
I added `"Chore"` which was missing in the documentations.
I added the missing tag for the ESLint commit convention. fix conventional-changelog#403
Also, not really related to this issue but wouldn't having |
Can you link where ESlint includes |
@stevemao There you go. |
Thanks so much! |
@stevemao Wouldn't updating the changelog for that package also update the rest or am I missing something in conventional-changelog-eslint? |
Sorry, What do you mean? |
Each package is independent. But they are often used together so we put them in a monorepo. Easier to dev/test. |
It makes sense, so what file(s) did I forgot to update with the relevant changes? |
That's what this PR updates tho. |
There might be some other parts need to be updated too. EG:
The link needs to be updated. I'm fine with updating it in a separate PR though if you think it's a better idea. |
@stevemao Just saw your comment (not sure why it went in my read notifications). |
The ESLint convention includes
Chore
which is what the ESLint team actively use, however it's not present on the README.EDIT: I'll open a PR once, all the local tests pass.
The text was updated successfully, but these errors were encountered: