Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag for ESLint convention #403

Closed
Berkmann18 opened this issue Jan 11, 2019 · 13 comments · Fixed by #404
Closed

Missing tag for ESLint convention #403

Berkmann18 opened this issue Jan 11, 2019 · 13 comments · Fixed by #404
Assignees
Labels
documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors. help wanted We need the community's help to address this issue through the contribution of a pull request.

Comments

@Berkmann18
Copy link
Contributor

Berkmann18 commented Jan 11, 2019

The ESLint convention includes Chore which is what the ESLint team actively use, however it's not present on the README.

EDIT: I'll open a PR once, all the local tests pass.

Berkmann18 added a commit to Berkmann18/conventional-changelog that referenced this issue Jan 11, 2019
I added `"Chore"` which was missing in the documentations.
Berkmann18 added a commit to Berkmann18/conventional-changelog that referenced this issue Jan 11, 2019
I added the missing tag for the ESLint commit convention.

fix conventional-changelog#403
@Berkmann18
Copy link
Contributor Author

Also, not really related to this issue but wouldn't having commitizen set up with the angular convention (since that's what is used on this repo) be a good idea?
I noticed it wasn't set up after git czing when I finished my PR which was set to ESLint.

@stevemao
Copy link
Member

Can you link where ESlint includes Chore? Also need to update https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-eslint

@Berkmann18
Copy link
Contributor Author

@stevemao There you go.
Okay, I'll update my PR with changes for that as well.

@stevemao
Copy link
Member

Thanks so much!

@Berkmann18
Copy link
Contributor Author

@stevemao Wouldn't updating the changelog for that package also update the rest or am I missing something in conventional-changelog-eslint?

@stevemao
Copy link
Member

Sorry, What do you mean?

@Berkmann18
Copy link
Contributor Author

@stevemao I mean, apart from updating conventional-changelog-eslint with that I did in #404, wouldn't it affect the whole repo instead of just that package?

@stevemao
Copy link
Member

Each package is independent. But they are often used together so we put them in a monorepo. Easier to dev/test.

@Berkmann18
Copy link
Contributor Author

It makes sense, so what file(s) did I forgot to update with the relevant changes?

@Berkmann18
Copy link
Contributor Author

That's what this PR updates tho.

@stevemao
Copy link
Member

There might be some other parts need to be updated too. EG:

Based on https://github.com/eslint/eslint.github.io/blob/master/docs/developer-guide/contributing.md#step-2-make-your-changes

The link needs to be updated. I'm fine with updating it in a separate PR though if you think it's a better idea.

@hutson hutson added documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors. help wanted We need the community's help to address this issue through the contribution of a pull request. labels Mar 24, 2019
@Berkmann18
Copy link
Contributor Author

@stevemao Just saw your comment (not sure why it went in my read notifications).
I've updated my PR with a correct URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors. help wanted We need the community's help to address this issue through the contribution of a pull request.
Development

Successfully merging a pull request may close this issue.

3 participants