Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(eslint): added "Chore" tag #404

Merged
merged 5 commits into from
Mar 26, 2019
Merged

docs(eslint): added "Chore" tag #404

merged 5 commits into from
Mar 26, 2019

Conversation

Berkmann18
Copy link
Contributor

I added the missing tag for the ESLint commit convention.

fix #403

@Berkmann18
docs(eslint): added "Chore" tag
4daf981 
I added the missing tag for the ESLint commit convention.

fix conventional-changelog#403
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.12% when pulling 4daf981 on Berkmann18:dev into 9249301 on conventional-changelog:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.12% when pulling 4daf981 on Berkmann18:dev into 9249301 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.12% when pulling 4daf981 on Berkmann18:dev into 9249301 on conventional-changelog:master.

@coveralls
Copy link

coveralls commented Jan 11, 2019 •
edited

Coverage Status

Coverage remained the same at 91.882% when pulling b06365e on Berkmann18:dev into fecb81c on conventional-changelog:master.

stevemao
stevemao reviewed Jan 13, 2019
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@stevemao
Copy link
Member

Thanks for the PR. Could you have a look at my comment in the issue?

@Berkmann18 Berkmann18 mentioned this pull request Jan 15, 2019
Closed
@Berkmann18
Copy link
Contributor Author

@stevemao Do you want me to revert the change on the package-lock.json?

@hutson hutson self-assigned this Mar 24, 2019
@hutson hutson added the documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors. label Mar 24, 2019
@hutson
Copy link
Contributor

hutson commented Mar 24, 2019

@stevemao Do you want me to revert the change on the package-lock.json?

@Berkmann18, can you please revert the package-lock.json file change. It's probably benign, but I personally like to avoid mixing concerns (package lock file updates with documentation changes).

@Berkmann18
Copy link
Contributor Author

@hutson Done.

hutson
hutson reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@hutson hutson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stevemao stevemao merged commit 2fef568 into conventional-changelog:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutson hutson hutson approved these changes

@stevemao stevemao stevemao approved these changes

Assignees

@hutson hutson

Labels
documentation Installation and usage guides, along with tutorials for developers, consumers, and contributors.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing tag for ESLint convention
4 participants
@Berkmann18 @coveralls @stevemao @hutson