Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license file #287

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Add license file #287

merged 1 commit into from
Mar 27, 2018

Conversation

jaredsmith
Copy link
Contributor

Add a license file with the license text of the MIT license.

Fixes #286

LICENSE.md Outdated
@@ -0,0 +1,21 @@
### MIT License

Copyright © [Steve Mao](https://github.com/stevemao)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the conventional-changelog team

@jaredsmith
Copy link
Contributor Author

I've changed the copyright holder. Is that acceptable?

@hutson
Copy link
Contributor

hutson commented Feb 22, 2018

@jaredsmith I believe the License file must be included within the sub-directory of each individual package so that when npm publish is executed within each sub-package, the License file will included in the published artifact.

Copy link
Contributor Author

@jaredsmith jaredsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this pull request to add a LICENSE.md file to each package.

@stevemao
Copy link
Member

Can you rebase and squash the commits?

@jaredsmith
Copy link
Contributor Author

OK, I've rebased and squashed the commits.

@@ -0,0 +1,21 @@
### MIT License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conventional-changelog-angular package uses the ISC license.

LICENSE.md Outdated
@@ -0,0 +1,21 @@
### MIT License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top-level package.json file specifies an ISC license.

@@ -0,0 +1,21 @@
### MIT License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conventional-changelog-atom package specifies an ISC license.

@jaredsmith
Copy link
Contributor Author

Good call -- I assumed they were all under the same license, but that was a bad assumption. The PR should reflect the actual license of each package now.

@hutson
Copy link
Contributor

hutson commented Mar 27, 2018

I assumed they were all under the same license

Our current license situation is definitely confusing. It's my hope that we'll consolidate to a single license across all Conventional Changelog projects. However that will likely require legal review.

This change, however, is a necessary first step in improving our licensing compliance. So thank you for putting in the work on this pull request.

👍 This change looks good to me.

@hutson hutson merged commit c7e0b43 into conventional-changelog:master Mar 27, 2018
@hutson
Copy link
Contributor

hutson commented Mar 27, 2018

Successfully published:

  • conventional-changelog-angular@3.0.4
  • conventional-changelog-atom@0.2.7
  • conventional-changelog-cli@1.3.19
  • conventional-changelog-codemirror@0.3.7
  • conventional-changelog-core@2.0.8
  • conventional-changelog-ember@0.3.9
  • conventional-changelog-eslint@1.0.8
  • conventional-changelog-express@0.3.6
  • conventional-changelog-jquery@1.3.7
  • conventional-changelog-jshint@0.3.7
  • conventional-changelog-preset-loader@1.1.8
  • conventional-changelog-writer@3.0.7
  • conventional-changelog@1.1.21
  • conventional-commits-parser@2.1.7
  • conventional-recommended-bump@2.0.8
  • git-raw-commits@1.3.6
  • git-semver-tags@1.3.6
  • gulp-conventional-changelog@1.1.21
  • standard-changelog@1.0.16

@hutson hutson self-assigned this Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants