-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license file #287
Add license file #287
Conversation
LICENSE.md
Outdated
@@ -0,0 +1,21 @@ | |||
### MIT License | |||
|
|||
Copyright © [Steve Mao](https://github.com/stevemao) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the conventional-changelog
team
I've changed the copyright holder. Is that acceptable? |
@jaredsmith I believe the License file must be included within the sub-directory of each individual package so that when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this pull request to add a LICENSE.md file to each package.
Can you rebase and squash the commits? |
OK, I've rebased and squashed the commits. |
@@ -0,0 +1,21 @@ | |||
### MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conventional-changelog-angular
package uses the ISC license.
LICENSE.md
Outdated
@@ -0,0 +1,21 @@ | |||
### MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top-level package.json
file specifies an ISC license.
@@ -0,0 +1,21 @@ | |||
### MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conventional-changelog-atom
package specifies an ISC license.
Good call -- I assumed they were all under the same license, but that was a bad assumption. The PR should reflect the actual license of each package now. |
Our current license situation is definitely confusing. It's my hope that we'll consolidate to a single license across all Conventional Changelog projects. However that will likely require legal review. This change, however, is a necessary first step in improving our licensing compliance. So thank you for putting in the work on this pull request. 👍 This change looks good to me. |
Successfully published:
|
Add a license file with the license text of the MIT license.
Fixes #286