Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: drop support for Node 8 #599

Merged
merged 1 commit into from
Feb 18, 2020
Merged

refactor!: drop support for Node 8 #599

merged 1 commit into from
Feb 18, 2020

Conversation

tommywo
Copy link
Member

@tommywo tommywo commented Feb 17, 2020

No description provided.

Copy link
Member

@stevemao stevemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it looks more like a chore to me. But LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.714% when pulling ef9135b on require-node-10 into ab58e7a on master.

@tommywo tommywo merged commit b9f5057 into master Feb 18, 2020
@stevemao stevemao deleted the require-node-10 branch February 18, 2020 11:09
jbottigliero pushed a commit to conventional-changelog/standard-version that referenced this pull request Jul 11, 2020
- The conventional-changelog packages that this repository relies on heavily have dropped support for NodeJS@8 (conventional-changelog/conventional-changelog/pull/599). While the current state (v8.0.0) of _this_ library still passes tests in NodeJS@8, with reaching EOL on 12/31/2019 this seems like a change we should introduce to avoid unexpected issues/conflicts with updates in dependencies.

see #549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants