fix(zh-hant): 約定式提交 -> 慣例式提交 #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackycute does this update look reasonable to you? |
|
How is this PR going? It's been 2 months since I opened it. |
|
This is a good question, I will dig deeper for this wording. |
|
IMO, I will translate "約定" into "Promise". |
jackycute
approved these changes
Apr 10, 2023
|
Hi @bcoe, I think what @hwhsu1231 purpose make sense. |
damianopetrungaro
approved these changes
Apr 17, 2023
hwhsu1231
added a commit
to hwhsu1231/conventionalcommits.org
that referenced
this pull request
Apr 17, 2023
* Update title of zh-hant in config.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #476