Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash after hibernating #1705

Closed
liori opened this issue Sep 10, 2019 · 1 comment
Closed

Crash after hibernating #1705

liori opened this issue Sep 10, 2019 · 1 comment
Labels
bug

Comments

@liori
Copy link

liori commented Sep 10, 2019 •
edited
Loading

Describe the bug
The anonymous instance converse.js at https://xmpp.org/chat?xsf crashes when suspending and waking up my PC.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://xmpp.org/chat?xsf and type some nickname.
  2. Suspend PC.
  3. Wake PC after few hours.
  4. See error

Expected behavior
The client reconnects and works.

Screenshots
https://imgur.com/a/Ay4VIVn

Environment (please complete the following information):

  • Ungoogled Chromium, from the About window: Version 72.0.3626.122 (Official Build) built on Debian stretch/9.9, running on Debian stretch/9.9 (64-bit)
  • Converse.js version 5.0.1
jcbrand added a commit that referenced this issue Sep 11, 2019
@jcbrand
Updates #1705. Add getRoomsPanel method to avoid dangling pointer
26c1dbb
@jcbrand
Copy link
Member

jcbrand commented Sep 11, 2019

I'm not exactly sure what the cause is, but I see this.roomspanel was undefined, so I added an accessor method to make sure it gets returned when needed. Hopefully that fixes it.

@jcbrand jcbrand added the bug label Sep 11, 2019
@jcbrand jcbrand closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcbrand @liori