-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Safari v7.0.5] TypeError: Attempted to assign to readonly property. #196
Comments
I think that refreshWebkit hack is actually only necessary for chrome and not for safari. On chrome, without the hack, if you close a chatbox that has boxes to the left of it, those boxes don't move to the right to fill the gap left by the closed chatbox. @g8g3 Can you perhaps check whether this bug occurs in Safari without that hack? In not, then we can add a more particular check there (only for Chrome). I don't have mac to test this with myself. |
I could not test on mac (i.e. with Safari 6+), but only emulate Safari 5. Maybe we could simply assign to the writable equivalent of conversejs.style.height = conversejs.offsetHeight; It works on Chrome and Safari 5. I'll check tomorrow if it's OK with Safari 6+. |
Cool, if it works will you please make a pull request? |
See: #196 and: requirejs/requirejs#392 updates #196
Safari v6+ forbids assigning to readonly properties in strict mode.
It occurs here in master.
The only workaround I've found is to disable strict mode.
See requirejs/requirejs#392 and PaulUithol/Backbone-relational#393 for similar issues.
The text was updated successfully, but these errors were encountered: