Display occupants avatar #1354
Closed
Display occupants avatar #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
requested changes
Nov 28, 2018
| 'image': "data:" + image_type + ";base64," + image, | ||
| }); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
There's no need to duplicate the code. Instead, in src/converse-chatboxviews.js, you can set AvatarMixin as an attribute on the _converse object.
Then further down you can do:
_converse.ViewWithAvatar = Backbone.NativeView.extend(_converse.AvatarMixin);
sass/_roster.scss
Outdated
| @@ -119,7 +119,9 @@ | |||
|
|
|||
| .avatar { | |||
| float: left; | |||
There was a problem hiding this comment.
We're using flexbox for many things now, so this float: left statement might no longer be necessary.
There was a problem hiding this comment.
Yes. In fact, I found it here, and when I tried to remove it, it broke the design. I'll try to remove it again and fix the display with flexbox.
|
This fixes #1322, btw. |
jcbrand
force-pushed
the
master
branch
3 times, most recently
from
8ca2731
to
f16b6d2
Compare
jcbrand
force-pushed
the
master
branch
2 times, most recently
from
d9824b4
to
c403708
Compare
jcbrand
force-pushed
the
master
branch
2 times, most recently
from
04f88d1
to
3e4f4e9
Compare
jcbrand
force-pushed
the
master
branch
2 times, most recently
from
37cfa36
to
f1899d0
Compare
jcbrand
force-pushed
the
master
branch
2 times, most recently
from
aa8c887
to
d7d810b
Compare
|
I've made some updates to this PR and then did a manual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a first contribution. There are some
I copied the AvatarMixin from chatbox-views, would have it been better to import the whole file, or maybe abstract this mixin in separate file ?