implement /destroy command in muc #1388
Conversation
ChaosKid42
force-pushed
the
implement_destroy_muc
branch
4 times, most recently
from
67f1ff6
to
5f8f315
Compare
jcbrand
force-pushed
the
master
branch
3 times, most recently
from
8ca2731
to
f16b6d2
Compare
There was a problem hiding this comment.
Thanks @ChaosKid42!
I have a few small improvement suggestions.
src/converse-muc-views.js
Outdated
| } | ||
| this.destroy( | ||
| this.model.get('jid'), args[0], | ||
| this.onDestroySuccess.bind(this), this.onCommandError.bind(this)); |
There was a problem hiding this comment.
Instead of making a new method onDestroySuccess, you can simply use this.close here, and you can use an arrow function to avoid having to use .bind.
In destroy, you can simply return _converse.api.sendIQ(iq) so that it returns a promise.
So it could be something like this:
this.destroy(this.model.get('jid'), args[0])
.then(() => this.close())
.catch(e => this.onCommandError(e));
src/converse-muc-views.js
Outdated
| const destroy = $build("destroy"); | ||
| const iq = $iq({to: groupchat, type: "set"}).c("query", {xmlns: Strophe.NS.MUC_OWNER}).cnode(destroy.node); | ||
| if (reason && reason.length > 0) { iq.c("reason", reason); } | ||
| return _converse.api.sendIQ(iq).then(onSuccess).catch(onError); |
There was a problem hiding this comment.
I'd like us to move away from using callbacks in favour of using promises.
Here, you can simply return return _converse.api.sendIQ(iq) and then later when you call destroy you can either use then and catch or async/await.
| spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback, errback) { | ||
| sent_IQ = iq; | ||
| IQ_id = sendIQ.bind(this)(iq, callback, errback); | ||
| }); |
There was a problem hiding this comment.
Not a dealbreaker for merging, but I'd like us to move away from using var in favour of let and const.
ChaosKid42
force-pushed
the
implement_destroy_muc
branch
2 times, most recently
from
564e03d
to
5ec837c
Compare
ChaosKid42
force-pushed
the
implement_destroy_muc
branch
from
5ec837c
to
2315ef1
Compare
|
@jcbrand Thanks fo your review. Updated the PR. |
This implements the possibility to destroy a MUC.