don't log error if user has no bookmarks #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaosKid42
force-pushed
the
fix_error_if_no_bookmarks
branch
from
9bf6d27
to
43add57
Compare
ChaosKid42
force-pushed
the
fix_error_if_no_bookmarks
branch
from
43add57
to
3248793
Compare
jcbrand
reviewed
Jan 9, 2020
| log.error(iq); | ||
| } | ||
| if (deferred) { | ||
| } else if (deferred) { | ||
| if (iq.querySelector('error[type="cancel"] item-not-found')) { | ||
| // Not an exception, the user simply doesn't have any bookmarks. | ||
| window.sessionStorage.setItem(this.fetched_flag, true); | ||
| return deferred.resolve(); | ||
| } else { | ||
| return deferred.reject(new Error("Could not fetch bookmarks")); |
There was a problem hiding this comment.
Here you still need to log an error though, otherwise we won't know what really went wrong.
There was a problem hiding this comment.
Updated accordingly.
There was a problem hiding this comment.
Thanks, sorry but the changelog entry needs to be moved to the top as well.
ChaosKid42
force-pushed
the
fix_error_if_no_bookmarks
branch
from
3248793
to
a98ce3b
Compare
jcbrand
requested changes
Jan 10, 2020
| log.error(iq); | ||
| } | ||
| if (deferred) { | ||
| } else if (deferred) { | ||
| if (iq.querySelector('error[type="cancel"] item-not-found')) { | ||
| // Not an exception, the user simply doesn't have any bookmarks. | ||
| window.sessionStorage.setItem(this.fetched_flag, true); | ||
| return deferred.resolve(); | ||
| } else { | ||
| return deferred.reject(new Error("Could not fetch bookmarks")); |
There was a problem hiding this comment.
Thanks, sorry but the changelog entry needs to be moved to the top as well.
ChaosKid42
force-pushed
the
fix_error_if_no_bookmarks
branch
from
a98ce3b
to
6cbecd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think converse should not log an error in case the user simply has no bookmarks.