feat(cxl-ui): [cxl-certificate-header] update completed page #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
anoblet
force-pushed
the
anoblet/feat/completed
branch
from
640b4f9
to
475426e
Compare
pawelkmpt
reviewed
Feb 23, 2024
There was a problem hiding this comment.
@anoblet why solution with MediaQueryController controller is better than simply hiding credential with CSS?
Especially in situation when _wideMediaQuery = '(min-width: 528px)'; is different from CSS MQ values (closest: $small: 568px).
anoblet
force-pushed
the
anoblet/feat/completed
branch
from
475426e
to
a3299fd
Compare
|
@pawelkmpt True. I was unsure which was the best strategy. Updated :) |
anoblet
force-pushed
the
anoblet/feat/completed
branch
3 times, most recently
from
81d332b
to
7a09568
Compare
pawelkmpt
force-pushed
the
anoblet/feat/completed
branch
from
7a09568
to
8fdc043
Compare
pawelkmpt
force-pushed
the
anoblet/feat/completed
branch
from
8fdc043
to
45dd30b
Compare
pawelkmpt
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86azbhf5m
Desktop:
Mobile: