Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly add wing interior to v-h tails #123

Merged
merged 3 commits into from
Oct 18, 2017
Merged

explicitly add wing interior to v-h tails #123

merged 3 commits into from
Oct 18, 2017

Conversation

mjburton11
Copy link

redefine fillModel in htail and vtail models

@mjburton11
Copy link
Author

test models please

1 similar comment
@mjburton11
Copy link
Author

test models please

@mjburton11 mjburton11 requested a review from bqpd October 17, 2017 01:24
@mjburton11
Copy link
Author

@galbramc @bqpd after some investigation, I believe when this run tests it's tests it is testing the research repos by checking out the gpkitmodels branch that is specified in each TESTCONFIG file. What is should do is check out the branch of the PR. The last push I did, ran all the test successfully in the PR but then once I pushed all of the research repos started failing for that reason.

@bqpd
Copy link
Contributor

bqpd commented Oct 17, 2017

oops yes I can see how that happened. will fix tomorrow.

@mjburton11
Copy link
Author

Great. This might allow us to stop specifying the gpkitmodels branch on TESTCONFIG and just always test on master.

@mjburton11
Copy link
Author

@bqpd ping

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

teset models please

@mjburton11
Copy link
Author

@bqpd what the heck, why is turbofan failing? and only on mac?

@bqpd
Copy link
Contributor

bqpd commented Oct 18, 2017

:(

@bqpd
Copy link
Contributor

bqpd commented Oct 18, 2017

looking into it

@bqpd
Copy link
Contributor

bqpd commented Oct 18, 2017

test models please

bqpd
bqpd approved these changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@bqpd bqpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bqpd
Copy link
Contributor

bqpd commented Oct 18, 2017

Now it passes. ? ? ?

@bqpd bqpd merged commit 39baa99 into master Oct 18, 2017
@bqpd bqpd deleted the tailfoam branch October 18, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqpd bqpd bqpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjburton11 @bqpd