Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up subbed vars; add wing testing method #127

Merged
merged 11 commits into from Oct 26, 2017
Merged

clean up subbed vars; add wing testing method #127

merged 11 commits into from Oct 26, 2017

Conversation

mjburton11
Copy link

No description provided.

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

@bqpd I added a testing method for the wing in wing_test.py how do we integrate testing with Jenkins for internal gpkitmodels testing?

@mjburton11
Copy link
Author

test models please

@mjburton11 mjburton11 requested a review from bqpd October 25, 2017 20:41
m.solve("mosek")

if __name__ == "__main__":
wing_test()
Copy link
Contributor

@bqpd bqpd Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, our first gplibrary test. I should add it to jenkins after this is merged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK perfect!

@mjburton11 mjburton11 merged commit f45cf25 into master Oct 26, 2017
@mjburton11 mjburton11 deleted the fixloading branch October 26, 2017 11:54
@mjburton11
Copy link
Author

@galbramc I just pushed this branch and jenkins has put this build in the queue and it seems to be stuck there and I don't know how to get it out.

@galbramc
Copy link

Yeah I saw it had been stuck for 20 hours. No idea what happened. I just killed it and triggered a new build. Looks like it's running now.

@mjburton11
Copy link
Author

odd, I tried to trigger a build about 20 hours ago, but it must have just got stuck in the queue. And then when I pushed again this morning it must have thought it didn't need to start another build. Is there any issue with my permissions maybe?

@mjburton11
Copy link
Author

On my end, it doesn't look like anything is running...

@mjburton11
Copy link
Author

just tried starting another build and it stuck me in the queue again.

@mjburton11
Copy link
Author

@bqpd this also should have never passed the tests. Because I deleted the input to lam in the wing model should it should have caused jho, gas_solar_trade, and solar to all fail...

@mjburton11
Copy link
Author

See #128 for fix

@mjburton11
Copy link
Author

@bqpd I think it's still testing all the repos on whatever branch is specified in TESTCONFIG, which is master for most of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants