Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create common materials models #141

Merged
merged 6 commits into from Dec 5, 2017
Merged

create common materials models #141

merged 6 commits into from Dec 5, 2017

Conversation

mjburton11
Copy link

No description provided.

@mjburton11 mjburton11 requested a review from bqpd December 1, 2017 02:15
@mjburton11
Copy link
Author

@bqpd not sure of the best way to go about doing this, see use case in convexengineering/solar@47040c1

Copy link
Contributor

@bqpd bqpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Next step, collapsing the various gravity variables into one? :p

@mjburton11
Copy link
Author

@bqpd One problem I'm having that you'll see the in the solar commit, is that I want the wing skin material, htail skin and vtail skin materials models to all be the same. I can do that with this approach, but the materials model that is used is like the 5th one that is created. I think because importing a model causes the materials model to be created? I'm wondering if there's a better way to do this.

@bqpd
Copy link
Contributor

bqpd commented Dec 2, 2017

(noting here that we met and discussed in lab doing this with instances created on import of gplibrary)

@mjburton11
Copy link
Author

test models please

@mjburton11 mjburton11 merged commit e1dd9cc into master Dec 5, 2017
@mjburton11 mjburton11 deleted the mat_create branch December 5, 2017 16:02
@@ -77,45 +75,10 @@ def box_spar():
W, fs, perf, loading])
m.solve(verbosity=0)

def materials():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd you remove the test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested that I could swap out the materials models to have a common material model for any use of CFRPFabric, but this became irrelevant once you import created models from the materials __init__.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, got it

@@ -0,0 +1,2 @@
from gpkit import Variable
g = Variable("g", 9.81, "m/s^2", "gravitational acceleration")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "near the earth's surface" ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm or just "earth surface?"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed directly to master. Sorry I should have asked you to review this again before merging...

@bqpd
Copy link
Contributor

bqpd commented Dec 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants