New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create common materials models #141
Conversation
@bqpd not sure of the best way to go about doing this, see use case in convexengineering/solar@47040c1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Next step, collapsing the various gravity variables into one? :p
@bqpd One problem I'm having that you'll see the in the solar commit, is that I want the wing skin material, htail skin and vtail skin materials models to all be the same. I can do that with this approach, but the materials model that is used is like the 5th one that is created. I think because importing a model causes the materials model to be created? I'm wondering if there's a better way to do this. |
(noting here that we met and discussed in lab doing this with instances created on import of gplibrary) |
test models please |
@@ -77,45 +75,10 @@ def box_spar(): | |||
W, fs, perf, loading]) | |||
m.solve(verbosity=0) | |||
|
|||
def materials(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why'd you remove the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested that I could swap out the materials models to have a common material model for any use of CFRPFabric, but this became irrelevant once you import created models from the materials __init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, got it
@@ -0,0 +1,2 @@ | |||
from gpkit import Variable | |||
g = Variable("g", 9.81, "m/s^2", "gravitational acceleration") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "near the earth's surface" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm or just "earth surface?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed directly to master. Sorry I should have asked you to review this again before merging...
naw worries!
…On Tue, Dec 5, 2017 at 11:17 AM, Michael Burton ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In gpkitmodels/__init__.py
<#141 (comment)>
:
> @@ -0,0 +1,2 @@
+from gpkit import Variable
+g = Variable("g", 9.81, "m/s^2", "gravitational acceleration")
I pushed directly to master. Sorry I should have asked you to review this
again before merging...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABagGMcoYpopbOrVb4-cj1K8DXL3l_yZks5s9WyrgaJpZM4Qxvhn>
.
|
No description provided.