Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for different spar in tailboom bending and flex models #146

Merged
merged 8 commits into from
Jan 10, 2018

Conversation

mjburton11
Copy link

No description provided.

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

test models please

@mjburton11 mjburton11 requested a review from bqpd December 18, 2017 17:07
@mjburton11
Copy link
Author

@bqpd please review. You have 24 hours... haha

@mjburton11 mjburton11 merged commit c8758c7 into master Jan 10, 2018
@mjburton11 mjburton11 deleted the boombeam branch January 10, 2018 13:36
@bqpd
Copy link
Contributor

bqpd commented Jan 10, 2018

oh no I missed it :o time limits are a good plan :D

beam["\\bar{\\delta}"][-1]*CLmax <= kappa
]

def makeTailBoom(N=2, tailboomSpar=TubeSpar):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to do this with classes instead of factories (the fancy name for functions-that-make-classes)...will take a look

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great if you could find a better way to do this.

tailLoad = TailBoomBending

def setup(self, N=N):
# exec parse_variables(TailBoom.__doc__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this commented out?

Copy link
Author

@mjburton11 mjburton11 Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't let me run an executive command inside a function...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yeah :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's super sad. That's why another way of doing this that would allow me to keep the exec functionality would be awesome.

emp, fs, htperf, vtperf, tbperf])

from gpkit import settings
if settings["default_solver"] == "cvxopt":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiiiinteresting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is interesting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got a collection of cvxopt hacks scattered around the gpkit tests as well; maybe at some point we can abstract them and integrate these observations into error messages / documentation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's not a bad idea

@@ -24,6 +24,7 @@ class BoxSpar(Model):
Sy [m^3] section modulus
dm [kg] segment spar mass
w [in] spar width
d [in] cross secitonal diameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/secitonal/sectional/

although secitonal sounds like a sweet word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants