-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for different spar in tailboom bending and flex models #146
Conversation
test models please |
test models please |
test models please |
@bqpd please review. You have 24 hours... haha |
oh no I missed it :o time limits are a good plan :D |
beam["\\bar{\\delta}"][-1]*CLmax <= kappa | ||
] | ||
|
||
def makeTailBoom(N=2, tailboomSpar=TubeSpar): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to do this with classes instead of factories (the fancy name for functions-that-make-classes)...will take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great if you could find a better way to do this.
tailLoad = TailBoomBending | ||
|
||
def setup(self, N=N): | ||
# exec parse_variables(TailBoom.__doc__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wouldn't let me run an executive command inside a function...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yeah :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's super sad. That's why another way of doing this that would allow me to keep the exec functionality would be awesome.
emp, fs, htperf, vtperf, tbperf]) | ||
|
||
from gpkit import settings | ||
if settings["default_solver"] == "cvxopt": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iiiiinteresting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is interesting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've got a collection of cvxopt hacks scattered around the gpkit tests as well; maybe at some point we can abstract them and integrate these observations into error messages / documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's not a bad idea
@@ -24,6 +24,7 @@ class BoxSpar(Model): | |||
Sy [m^3] section modulus | |||
dm [kg] segment spar mass | |||
w [in] spar width | |||
d [in] cross secitonal diameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/secitonal/sectional/
although secitonal sounds like a sweet word
No description provided.