Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for outboard loads on wing as signomial model #163

Merged
merged 9 commits into from
Apr 21, 2018
Merged

Conversation

mjburton11
Copy link

No description provided.

@mjburton11 mjburton11 requested a review from bqpd April 20, 2018 13:19
@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

@bqpd I get this error running with this branch on JHO

"/Users/jenkins/workspace/gplibrary_PR_Models/mosek/gpkit/gpkit/small_classes.py", line 242, in __div__
    def __div__(self, other): return self * other**-1
ZeroDivisionError: 0.0 cannot be raised to a negative power

@mjburton11
Copy link
Author

test models please

@mjburton11
Copy link
Author

@bqpd solved the 0.0 issue. I was substituting in values where I shouldn't have been.

@mjburton11 mjburton11 requested a review from courtin April 20, 2018 19:30
@bqpd
Copy link
Contributor

bqpd commented Apr 20, 2018

@mjburton11 should I try to clarify the error message?

@mjburton11
Copy link
Author

That could be helpful

@bqpd
Copy link
Contributor

bqpd commented Apr 20, 2018

Where were you dividing the Hashvector?

@mjburton11
Copy link
Author

I think so? I was diving the hmap or something like that

@bqpd
Copy link
Contributor

bqpd commented Apr 20, 2018

Hmm. I feel like adding a more specific error might not help debugging much more than debug lines in user code would.

@mjburton11
Copy link
Author

@bqpd @courtin can one of you review this PR so I can merge?

theta [-] twist deflection

Upper Unbounded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd you remove all the bounds? :p

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the bounds because it got really annoying as I was debugging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think they're a useful feature overall? (during dev you can add SKIP VERIFICATION to disable checking)

"\\bar{\\delta}_{root}", "\\theta_{root}"]:
l.substitutions[v] = 1e-3
for v in ["Mtip", "Stip", "wroot", "throot"]:
l.substitutions[v] = 1e-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh why so much larger?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. But it gave me unknown at 1e-2 so...

@mjburton11 mjburton11 merged commit 3a49468 into master Apr 21, 2018
@mjburton11 mjburton11 deleted the outboardloads branch April 21, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants