python3 compatibility #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test models please |
|
test models please |
|
@bqpd what do we do since model tests fail? I would like to merge this ASAP since tests run on master, and I need parts of gplibrary for robust. Lmk. |
|
@1ozturkbe model tests need to pass before you merge onto gplibrary...they're a lot of what actually tests gplibrary's functionality! The error seems to have been in the converter's use of |
|
oops, forget to check it still worked with python 3...latest commit fixes that. |
|
test models please |
|
Ready to merge after review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.