-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3 compatibility #176
Conversation
test models please |
test models please |
@bqpd what do we do since model tests fail? I would like to merge this ASAP since tests run on master, and I need parts of gplibrary for robust. Lmk. |
@1ozturkbe model tests need to pass before you merge onto gplibrary...they're a lot of what actually tests gplibrary's functionality! The error seems to have been in the converter's use of |
oops, forget to check it still worked with python 3...latest commit fixes that. |
test models please |
Ready to merge after review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Will merge.
No description provided.