fix cap spar weight; cmac calculation #121
Conversation
|
@bqpd is it possible to set up the integrated testing yet for PRs? I don't want to merge and then break everything, like I may have accidentally done on jho... |
|
test models please |
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
sweet! this is dope! |
|
(had a bug in the jenkins script) |
|
test models please |
|
Do you have to say "test models please" to get this to retest? |
|
yup! my thinking was that eventually there'll be a regular library test which can be tested separately (since it won't require importing every dang thing) |
|
haha that was smart |
|
test this please |
|
test models please |
|
@bqpd this failed due to a turbofan model failing. But I don't think that depends on gpkitmodels... It also only failed on Windows... |
|
test models please |
|
test models please |
|
Weird, why is this PR showing as making no changes? |
|
woah, yeah what is going on? |
|
also why did it magically past tests all of a sudden? |
|
the turbofan failure is erratic |
|
the no-changes is confirmed on my local git |
|
I did an update branch.. would that have changed it? |
|
naw, the previous commit also had no changes...confirmed by checking the file on master. What changes should this be making? |
|
It was supposed to update an incorrect constraint in capspar and fix a bad substitution |
|
If you look at the commits on this PR I clearly changes so... |
|
But all the changes they make are already in master |
|
If I checkout 3e26eb5, it has all the changes that I expect |
|
I think your earlier commit titled |
|
Oh..... yeah, my bad |
|
So should I just delete this PR? |
|
probably... |
No description provided.