Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing tests #8

Closed
whoburg opened this issue May 14, 2017 · 38 comments · Fixed by #11
Closed

failing tests #8

whoburg opened this issue May 14, 2017 · 38 comments · Fixed by #11

Comments

@whoburg
Copy link
Collaborator

whoburg commented May 14, 2017

@mayork, do you know why this is failing tests? Can we get them passing reliably?

@mayork
Copy link
Contributor

mayork commented May 14, 2017

not sure, I'll look into it. What's odd is it is only failing on some machines...

@whoburg
Copy link
Collaborator Author

whoburg commented May 14, 2017

maybe the test method has fallen out of sync with what's in __main__? Those should probably rely on the same code

@mayork
Copy link
Contributor

mayork commented May 15, 2017

resolved. test and main were out of sync slightly.

@mayork mayork closed this as completed May 15, 2017
@bqpd
Copy link
Contributor

bqpd commented May 16, 2017

@mayork, @1ozturkbe, should we use __main__ instead of test?

@mayork
Copy link
Contributor

mayork commented May 16, 2017

No I don't think so. This was just poorly formulated on my part. Fixed inD8.

@whoburg
Copy link
Collaborator Author

whoburg commented Jun 21, 2017

tests are failing again.

@whoburg whoburg reopened this Jun 21, 2017
@mayork
Copy link
Contributor

mayork commented Jun 21, 2017

I haven't pushed to this in a while...odd...on vacation now I'll take a look in a few days.

@whoburg
Copy link
Collaborator Author

whoburg commented Jul 3, 2017

status on this? Sporadic test failures are continuing.

@whoburg
Copy link
Collaborator Author

whoburg commented Jul 3, 2017

@mayork and/or @1ozturkbe if one of you could prioritize this I'd appreciate it, I really want us to find it unacceptable when tests are failing. Makes us less likely to break things when improving GPkit.

@mayork
Copy link
Contributor

mayork commented Jul 3, 2017

sorry had some family things come up and have had to take an unexpected trip to SC. I think I've narrowed it down to to two possible causes...the fix for once of which is just making a better testing framework within the turbofan repo, which I've started working on. Should be pushed soon.

@mayork
Copy link
Contributor

mayork commented Jul 3, 2017

i made a series of updates that I think should have resolved this issue but it looks like there's now an import error within the model testing code on windows7x64... @bqpd what is going on here? The relevant output is at https://acdl.mit.edu/csi/job/gpkit_ResearchModel_turbofan_Push/buildnode=windows7x64,optimizer=mosek/125/console

@bqpd
Copy link
Contributor

bqpd commented Jul 3, 2017 via email

@mayork
Copy link
Contributor

mayork commented Jul 3, 2017

it hung and eventually solved...i just made another push and got the exact same error

@bqpd
Copy link
Contributor

bqpd commented Jul 3, 2017 via email

@mayork
Copy link
Contributor

mayork commented Jul 3, 2017

resolved that i'll see what happens on the current run

@mayork
Copy link
Contributor

mayork commented Jul 3, 2017

hmm it's all passing now

@mayork
Copy link
Contributor

mayork commented Jul 3, 2017

hmm well got 2 successful builds in a row. I'm going to close this for now, not sure what the import error was but it seems to have resolved itself. I think the turbofan tests should be much more stable now. I removed the possibility of having main and tests run with different substitutions.

@mayork mayork closed this as completed Jul 3, 2017
@whoburg
Copy link
Collaborator Author

whoburg commented Jul 7, 2017

Still failing

@whoburg whoburg reopened this Jul 7, 2017
@mayork
Copy link
Contributor

mayork commented Jul 7, 2017

@bqpd what are your thoughts on this. I'm not sure what to do because I cannot recreate any sort of failing behavior on my machine.

@bqpd
Copy link
Contributor

bqpd commented Aug 28, 2017

@mayork, this never fails on your machine?

@mayork
Copy link
Contributor

mayork commented Aug 28, 2017

Nope! I almost think there's some issue with testing large SPs

@bqpd
Copy link
Contributor

bqpd commented Aug 28, 2017

hmm...across multiple platforms? I'll check if I can reproduce this failure & get back to you.

@mayork
Copy link
Contributor

mayork commented Aug 28, 2017

For what's it worth I think the mosek failure is almost exclusively mosek_cli. Not sure why, seems like it shouldn't make a difference.

@bqpd
Copy link
Contributor

bqpd commented Aug 28, 2017

That's generally a sign of knife-edge...mosek_cli prints and reads floats from text files, causing some rounding.

@mayork
Copy link
Contributor

mayork commented Aug 28, 2017

@bqpd I don't think it's knife edge...but....could the tex file rounding cause some issues for the signommial equalities? That is by far the least reliable constraint and is in both the engine and SP aircraft, the two places we are seeing this issue...

@bqpd
Copy link
Contributor

bqpd commented Aug 28, 2017

I guess 'knife edge' is a loaded word; I mean there's some effect where the program either converges to a good solution or to NEAR_OPTIMAL/UNKNOWN, and I think that the balance between those depends on very small effects (such as the text file rounding). Signomial Equalities seem more likely to have extreme approximations, so maybe?

@mayork
Copy link
Contributor

mayork commented Sep 25, 2017

@1ozturkbe @bqpd did migrating the repo cause issues with the testing? I pushed to this repo and tests did not run.

@galbramc

@bqpd
Copy link
Contributor

bqpd commented Sep 26, 2017

I forgot to invite @acdl-jenkins to be an admin in the new org...once their invite is accepted, the webhooks should start working again.

@galbramc
Copy link
Contributor

@bqpd, I need to update the jenkins website it self to point to the new URL for this repo

@bqpd
Copy link
Contributor

bqpd commented Sep 26, 2017

ah, I thought I did that (for turbofan)

@galbramc
Copy link
Contributor

yeah I think you did, I just went through and updated everything else. We need a pull request in this repo to test it out though.

@galbramc
Copy link
Contributor

Looks like I can manually trigger the push test at least, but we need someone to push to the repo to be sure.

@mjburton11
Copy link

@mayork @1ozturkbe can we please make this more reliable? gpkitmodels is setup on jenkins so every time we push this has to pass and it fails 2/3 of time and is very annoying.

@mayork
Copy link
Contributor

mayork commented Oct 15, 2017 via email

@galbramc
Copy link
Contributor

Are the files lacking precision for the cli printed with insufficient precision? Can you increase the digits in the floating point numbers?

@mjburton11
Copy link

can you skip that solver?

@bqpd
Copy link
Contributor

bqpd commented Oct 15, 2017

(you can definitely just add that to skipsolvers in TESTCONFIG)

@mayork
Copy link
Contributor

mayork commented Oct 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants