Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to Boston fare router #655

Draft
wants to merge 46 commits into
base: dev
Choose a base branch
from

Commits on Nov 24, 2020

  1. refactor(point-to-point): remove unnecessary CORS headers, all use of…

    … point-to-point router server is internal
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    c0ad73e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4e2823 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5af23e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20ae03d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0db2b87 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    87e09e0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4818578 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1eab3b5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    87e5e80 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    65eab0a View commit details
    Browse the repository at this point in the history
  11. feat(fares-v2): improve performance by precalculating fare transfer r…

    …ules for all from leg groups
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    e4d570f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    33b75aa View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a5e4766 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    78db523 View commit details
    Browse the repository at this point in the history
  15. feat(fares-v2): add hack to compute as_route fare based on all statio…

    …ns traversed, not from and to station
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    629a3e1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    0931547 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f810c77 View commit details
    Browse the repository at this point in the history
  18. docs(fares-v2): additional comment updates.

    Co-authored-by: Anson Stewart <astewart@conveyal.com>
    mattwigway and ansoncfit committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    25d4517 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ca2414c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    30aa94d View commit details
    Browse the repository at this point in the history
  21. feat(gtfs-fares-v2): make the search process a lot faster by replacin…

    …g bitset comparison with int comparison.
    
    Previously we compared whether a leg had a superset of the potentially-active fare transfer rules of another leg, but
    because most fare_transfer_rules specify a from_leg_group_id, the superset would only be active in a few cases:
    1) when there are transfer rules with no from_leg_group_id
    2) when two trips have the same price but one has no transfer allowance
    3) when the two trips have the same previous leg group
    
    99% of the time (not measured), it was the third condition that eliminated legs. We can implement the third condition with a simple integer equality, rather than a BitSet operation. The others are rare enough that ignoring them makes us retain maybe a few more trips, but not enough to outweight the performance penalty of a big BitSet comparison.
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    fb23694 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    98745fa View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    e4b0e84 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    65d0cbd View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    97dc47f View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    413e356 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    94d1c77 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    7538dcd View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    07d1ac8 View commit details
    Browse the repository at this point in the history
  30. fix(boston-fares): correctly compare out-of-subway fares (fixes conve…

    …yal#593) and use boston-specific logic in dominance (addresses conveyal#595)
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    16e5a03 View commit details
    Browse the repository at this point in the history
  31. fix(fares): throw UnsupportedOperationException when tightenExpiratio…

    …n called in superclass, adresses conveyal#595.
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    b437360 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    85eb964 View commit details
    Browse the repository at this point in the history
  33. fix(fares): throw UnsupportedOperationException when superclass tight…

    …enExpiration called unsafely.
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    3d0b471 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    fc7b0c8 View commit details
    Browse the repository at this point in the history
  35. Revert "fix(boston-fares): allow same-direction transfers on commuter…

    … rail."
    
    This reverts commit db439cf0ebe9725d3d01dc72cdedc369d489f85d.
    
    Allowing free transfers on commuter rail violates nonnegativity of transfer allowances.
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    7e3dd62 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    59c73a8 View commit details
    Browse the repository at this point in the history
  37. fix(bos-fares): make sure that max transfer allowance is set correctl…

    …y after riding the silver line for free
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    a6e34af View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    5680700 View commit details
    Browse the repository at this point in the history
  39. fix(boston-fares): do not allow virtual behind gates transfer at airp…

    …ort when original boarding was SL_FREE
    mattwigway committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    640d547 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    6061e38 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    48a17ac View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    adc2d1e View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    0536add View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    5e8a656 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. fix(http-api): remove cors in local mode (see proxy-backend branch of…

    … mattwigway/analysis-ui)
    mattwigway committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    29affbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c13a80 View commit details
    Browse the repository at this point in the history