BostonInRoutingFareCalculator incorrectly calculates fare for Bus -> Subway -> Subway

[mattwigway]

BostonInRoutingFareCalculator is reporting a fare for Route 442 (local bus) to Blue Line to Orange Line as costing $4.50, even though the bus to blue line transfer is a $0.55 upgrade to the $1.70 local bus fare, and the subsequent orange line transfer is free. It appears that we are only considering behond-the-gates transfers as a possibility when the original transfer allowance is from the subway, not from a local bus.

[ansoncfit]

Thanks for reporting. Does the suggested fix correctly handle local bus to commuter rail to subway?

[mattwigway]

Yes it does - issuing is kept separately from previous, and previous is only used for subway to subway transfers. For example, this route (link to Fareto running on localhost just to record parameters) takes local 436 to the Newburyport/Rockport line at Lynn to the green line at North Station, and correctly is charging $9.00: $1.70 for the bus, $6.75 Zone 2 from Lynn to N Station, and a $0.55 upgrade to the subway.

[mattwigway]

Or this similar route which again takes local 436 to Lynn, Newburyport/Rockport to N Station, Green to Park, and Red to Broadway for $9.

[mattwigway]

Or this similar route which shows that bus-subway-bus still works: local bus to Lynn, N/R to N Station, Orange to Tufts, 9 to Southie, also $9.