Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Convos::Plugin::Auth::Header, closes #696 #702

Merged
merged 1 commit into from
Mar 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions lib/Convos/Plugin/Auth/Header.pm
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
package Convos::Plugin::Auth::Header;
use Mojo::Base 'Convos::Plugin::Auth', -async_await;

has admin_user => sub { $ENV{CONVOS_ADMIN} // 'admin-email-not-set@example.com' };
has x_user_header_name => sub { $ENV{CONVOS_AUTH_HEADER} || 'X-Authenticated-User' };

sub register {
my ($self, $app, $config) = @_;
$self->SUPER::register($app, $config);
$self->admin_user($config->{admin_user}) if defined $config->{admin_user};
$self->x_user_header_name($config->{x_user_header_name}) if $config->{x_user_header_name};
$app->helper('user.load_p' => sub { $self->_user_load_p(@_) });
}

async sub _user_load_p {
my ($self, $c) = @_;
my $core = $c->app->core;

my $header = $self->x_user_header_name;
my $email = $c->req->headers->header($header);
return _giveup($c, debug => "Header $header is missing in request.") unless $email;

my $user = $email && $core->get_user({email => $email});
return $user if $user;

if (!$core->n_users and $self->admin_user and $email ne $self->admin_user) {
my $admin = $self->admin_user;
return _giveup($c, warn => "Cannot auto-register user, when admin $admin is not registered.");
}

$c->app->log->info("Auto-registering user $email from header $header");
return $core->user({email => $email})->save_p;
}

sub _giveup {
my ($c, $level, $msg) = @_;
$c->log->$level($msg);
return undef;
}

1;

=encoding utf8

=head1 NAME

Convos::Plugin::Auth::Header - Authenticate users by verifying reverse proxy header

=head1 SYNOPSIS

$ CONVOS_PLUGINS=Convos::Plugin::Auth::Header \
CONVOS_ADMIN=admin@example.com \
CONVOS_AUTH_HEADER=X-User \
./script/convos daemon

C<CONVOS_ADMIN> defaults to C<admin-email-not-set@example.com>, but can be set
to the Convos admin user's email address to I<disallow> anyone else to register
as a normal user before the admin has registered/logged in. Setting this
enviroment variable to an empty string will make the first user the admin user.

C<CONVOS_AUTH_HEADER> must contain the header name that will contain the email
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I use just a string instead of an email address for an user identifier? That would be very usefuld, except if an email is required for some other reason.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Email is the unique identifier for a user, so that is required. If you only have a string, you could potentially fake it and just add "@convos" at the end. (The domain part is not validated)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks!

address of the logged in user. The default value is "X-Authenticated-User", but
can be set to "X-User" or any value you like. Do make sure though that this
header cannot be set from user request!

=head1 DESCRIPTION

L<Convos::Plugin::Auth::Header> is used to register and login users based on a
header set in a reverse proxy web server, such as nginx.

=head1 HELPERS

=head2 user.load_p

$user = await $c->user->load_p($email);
$user = await $c->user->load_p;

See L<Convos::Plugin::Auth/user.load_p> for details.

=head1 METHODS

=head2 register

$auth->register($app, \%config);

=head1 SEE ALSO

L<Convos::Plugin::Auth>, L<Convos>.

=cut
55 changes: 55 additions & 0 deletions t/plugin-auth-header.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
#!perl
use lib '.';
use t::Helper;

$ENV{CONVOS_PLUGINS} = 'Convos::Plugin::Auth::Header';
$ENV{CONVOS_BACKEND} = 'Convos::Core::Backend';

my $t = t::Helper->t;

subtest 'not authorized' => sub {
$t->get_ok('/api/user')->status_is(401);
$t->post_ok('/api/user/login',
json => {email => 'superwoman@example.com', password => 'superduper'})->status_is(400);
};

subtest 'admin is required' => sub {
local $ENV{CONVOS_ADMIN} = 'admin@convos.chat';
my %headers = ('X-Authenticated-User' => 'superman@example.com');
$t->get_ok('/api/user', \%headers)->status_is(401);

$headers{'X-Authenticated-User'} = $ENV{CONVOS_ADMIN};
$t->get_ok('/api/user', \%headers)->status_is(200);

$headers{'X-Authenticated-User'} = 'superman@example.com';
$t->get_ok('/api/user', \%headers)->status_is(200);
};

subtest 'unable to register or login' => sub {
$t->post_ok('/api/user/register',
json => {email => 'superwoman@example.com', password => 'longenough'})->status_is(401);

$t->post_ok('/api/user/register',
json => {email => 'superman@example.com', password => 'longenough'})->status_is(401);

$t->post_ok('/api/user/login', json => {email => 'superman@example.com', password => ''})
->status_is(400);

$t->post_ok('/api/user/login',
json => {email => 'superman@example.com', password => 'no_password_in_storage'})
->status_is(400);
};

subtest 'login enabled after changing password' => sub {
$t->post_ok('/api/user/superman@example.com', json => {password => 'cool_beans_123'})
->status_is(401);

my %headers = ('X-Authenticated-User' => 'superman@example.com');
$t->post_ok('/api/user/superman@example.com', \%headers, json => {password => 'cool_beans_123'})
->status_is(200);

$t->post_ok('/api/user/login',
json => {email => 'superman@example.com', password => 'cool_beans_123'})->status_is(200);
};

done_testing;