Allow for different AMI types for build node #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr @beastawakens |
beastawakens
force-pushed
the
allow-different-build-node-amitype
branch
from
1bd5122
to
5f4d7e1
Compare
@nightfury1204 Done! |
nightfury1204
temporarily deployed
to
UpgradeDowngradeTests
GitHub Actions
Inactive
nightfury1204
had a problem deploying
to
UpgradeDowngradeTests
GitHub Actions
Error
nightfury1204
added a commit
that referenced
this pull request
Jul 26, 2023
* Bootstrap read access authorization * Add rack api access access mechanism * Add doc for rack access cmd * Refactor telemetry work (#666) * update golang.org/x/text to v0.11.0 * Use plural for duration in hours * set random_id for build node if build node enabled * Allow for different AMI types for build node --------- Co-authored-by: nightfury1204 <knightnahid@gmail.com>
lucasmacedot
added a commit
to DNXLabs/convox
that referenced
this pull request
Aug 2, 2023
commit 9109117 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Mon Jul 24 17:06:33 2023 +0100 Add force promote or deploy option (convox#672) commit bc097d5 Author: Ed Fricker <888909+beastawakens@users.noreply.github.com> Date: Fri Jul 21 19:43:41 2023 +0100 Allow for different AMI types for build node (convox#669) * Bootstrap read access authorization * Add rack api access access mechanism * Add doc for rack access cmd * Refactor telemetry work (convox#666) * update golang.org/x/text to v0.11.0 * Use plural for duration in hours * set random_id for build node if build node enabled * Allow for different AMI types for build node --------- Co-authored-by: nightfury1204 <knightnahid@gmail.com> commit c9d5271 Author: nightfury1204 <knightnahid@gmail.com> Date: Mon Jul 10 22:54:52 2023 +0100 set random_id for build node if build node enabled commit a3ab575 Author: nightfury1204 <knightnahid@gmail.com> Date: Mon Jul 10 18:22:05 2023 +0100 Use plural for duration in hours commit 2e398c9 Author: nightfury1204 <knightnahid@gmail.com> Date: Mon Jul 10 17:25:36 2023 +0100 update golang.org/x/text to v0.11.0 commit 77ea454 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Mon Jul 10 17:20:05 2023 +0100 Refactor telemetry work (convox#666) commit e73fee7 Author: nightfury1204 <knightnahid@gmail.com> Date: Fri Jun 30 13:00:44 2023 +0100 Add doc for rack access cmd commit 8501073 Author: nightfury1204 <knightnahid@gmail.com> Date: Thu Jun 22 23:15:35 2023 +0100 Add rack api access access mechanism commit cb3ed23 Author: nightfury1204 <knightnahid@gmail.com> Date: Thu Apr 20 14:37:44 2023 +0100 Bootstrap read access authorization commit 1c6972a Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Mon Jun 26 15:39:34 2023 +0100 Add custom label support (convox#658) commit 367e180 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Wed Jun 21 11:25:04 2023 +0100 Feat k8s 1.25 (convox#657) * k8s 1.25 update * Update to go 1.18 * update ebs csi driver * CronJob to batch/v1 * Update do and gcp version * Fix azure dependency on resource group commit cfd1d02 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Fri Jun 16 20:59:16 2023 +0100 Add grpc support (convox#656)
beastawakens
added a commit
that referenced
this pull request
Sep 12, 2023
* Bootstrap read access authorization * Add rack api access access mechanism * Add doc for rack access cmd * Refactor telemetry work (#666) * update golang.org/x/text to v0.11.0 * Use plural for duration in hours * set random_id for build node if build node enabled * Allow for different AMI types for build node --------- Co-authored-by: nightfury1204 <knightnahid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case where the build node can be a non-GPU instance to build the image, but the application runs on a GPU instance means we should allow for different AMI types for the build node cluster.
Probably less of a use-case between ARM/non-ARM clusters but if someone wants to do that, why not? 馃槅