Feat: Option to force release promote #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightfury1204
added a commit
that referenced
this pull request
Jul 26, 2023
lucasmacedot
pushed a commit
to DNXLabs/convox
that referenced
this pull request
Aug 2, 2023
[Telemetry] Send params on Rack Install, Rack Update and Rack Params Set. (convox#627) * Change rack name (convox#589) * Add rack_name to the vars It will be used to set the rack name * Add rack name to the nanespace label * Change the rack name before it's moved to the console or locally * Fix tests about terraform * Add rack_name to all providers * fix: Add fix for aws gov cloud (convox#609) * Add fix for aws gov cloud * Fix attribute not found error when terraform destroy * Remove outdated code and unused lib (convox#611) * Set default value for rack_name on tf files * Add fix for route table and bucket acl not allowed error * Store rack install & rack install update telemetry data (convox#608) * Cli command to activate or desactivate cli telemetry * unit test for the cli cmd * Send telemetry params on rack install and rack params set * CLI docs * Changing approach: The telemetry data will be send by the terraform after all infra will be provisioned * Add resource telemetry on all providers * Extract telemetry for a different module * add telemetry param * Fix unit test * Define a k8s configmap with the values on vars.json. * Get params from configmap and sync with metrics app * Anonymize params * Redact rack_name * refactoring to improve quality on the function to create sync cm * set telemetry var as true as default * Fix deepsource terraform warnings * Fix unit tests * Fix deepsource go warnings * Change telemetry type to boolean * create the configmap just if the settings dir is set (convox#622) * Try to restrict settings variable to only new releases * Fix minor version check for telemetry support * remove prints * rollback go syntax: init toSync map * rollback release version check * Fix deepsource report * Fix unit tests * Remove diff strategy * rack_params as a prefix * Put telemetry off as default for next release * fix unit tests * Fix deepsource * not necessary update sync configmap anymore * Put the right minor version supported * refactoring check if release is supported * try a patch release --------- Co-authored-by: Taynan <Twsouza@users.noreply.github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> Fix internal router (convox#633) Add spot and on_demand instance count in telemetry (convox#621) * Add spot and on_demand instance count in telemetry * Put the login in seperate funtion Fix: fix azure rack install (convox#635) * Azure fix * Fix build security context bug * Update buildkit version Add subnets as variables Change use of `aws_subnet.private` to `var.private_subnets_ids` Add test files Convert params from `map[string]string` to `map[string]interface{}` Revert methods.go Revert pkg/api changes Revert pkg/cli changes Revert pkg/console changes Revert pkg/structs changes Revert pkg/rack changes Add break of interfaces for terraform variables Fix test files Revert cli changes Remove cli test file Change main subnets variable to string, add public subnets Fix subnets of node group Add gateways Fix-821: Local rack fix for minikube (convox#551) * remove hostNetwork config for agents (convox#549) * remove hostNetwork config for agents * Adding CodeOwners to request approve when a PR is open to merge on master * Changes CodeOwners team * update documentation Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Fix for local v3 rack install for minikube * set type of resolver-external as 'ClusterIP' only * Remove the dummy selector * Use public dns resolver to resolve the minikube ip * Add seperate domain for mac --------- Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> Update-821: Dev rack and misc docs Update-821: Dev rack and misc docs-2 Remove nat gateway from locals Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review Revert changes on `pkg/cli/login.go` Revert changes on `pkg/rack/console.go` Remove comments Remove unecessary comment Add compact Fix use of route table when only passing VPC Create rack using existing subnets (convox#563) * Add subnets as variables * Change use of `aws_subnet.private` to `var.private_subnets_ids` * Add test files * Convert params from `map[string]string` to `map[string]interface{}` * Revert methods.go * Revert pkg/api changes * Revert pkg/cli changes * Revert pkg/console changes * Revert pkg/structs changes * Revert pkg/rack changes * Add break of interfaces for terraform variables * Fix test files * Fix-821: Local rack fix for minikube (convox#551) * remove hostNetwork config for agents (convox#549) * remove hostNetwork config for agents * Adding CodeOwners to request approve when a PR is open to merge on master * Changes CodeOwners team * update documentation Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Fix for local v3 rack install for minikube * set type of resolver-external as 'ClusterIP' only * Remove the dummy selector * Use public dns resolver to resolve the minikube ip * Add seperate domain for mac --------- Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Update-821: Dev rack and misc docs * Update-821: Dev rack and misc docs-2 * Update-821: Dev rack and misc docs-3 * Revert cli changes * Remove cli test file * Change main subnets variable to string, add public subnets * Fix subnets of node group * Add gateways * Remove nat gateway from locals * Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review * build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0 (convox#575) * Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review * Change dependabot to open PRs to the staging branch (convox#573) * build(deps): bump github.com/creack/pty from 1.1.13 to 1.1.18 (convox#467) Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.13 to 1.1.18. - [Release notes](https://github.com/creack/pty/releases) - [Commits](creack/pty@v1.1.13...v1.1.18) --- updated-dependencies: - dependency-name: github.com/creack/pty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0 Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.3 to 1.8.0. - [Release notes](https://github.com/gorilla/mux/releases) - [Commits](gorilla/mux@v1.7.3...v1.8.0) --- updated-dependencies: - dependency-name: github.com/gorilla/mux dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Revert changes on `pkg/cli/login.go` * Revert changes on `pkg/rack/console.go` * Remove comments * Remove unecessary comment --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> Co-authored-by: Nick <nthoni@hotmail.com> Co-authored-by: Taynan <Twsouza@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Add docs of subnets Change rack name (convox#589) * Add rack_name to the vars It will be used to set the rack name * Add rack name to the nanespace label * Change the rack name before it's moved to the console or locally * Fix tests about terraform * Add rack_name to all providers fix: Add fix for aws gov cloud (convox#609) * Add fix for aws gov cloud * Fix attribute not found error when terraform destroy Remove outdated code and unused lib (convox#611) Set default value for rack_name on tf files Fix rack markdown newline Remove duplicate `wait_for_cluster` Revert unused files Only use rack_name on a supported version (convox#618) * Rack install, move or update will only attach rack_name if it's on a supported version * Fix tests Remove duplicate variables on aws Add `data.aws_nat_gateway`
lucasmacedot
pushed a commit
to DNXLabs/convox
that referenced
this pull request
Aug 2, 2023
[Telemetry] Send params on Rack Install, Rack Update and Rack Params Set. (convox#627) * Change rack name (convox#589) * Add rack_name to the vars It will be used to set the rack name * Add rack name to the nanespace label * Change the rack name before it's moved to the console or locally * Fix tests about terraform * Add rack_name to all providers * fix: Add fix for aws gov cloud (convox#609) * Add fix for aws gov cloud * Fix attribute not found error when terraform destroy * Remove outdated code and unused lib (convox#611) * Set default value for rack_name on tf files * Add fix for route table and bucket acl not allowed error * Store rack install & rack install update telemetry data (convox#608) * Cli command to activate or desactivate cli telemetry * unit test for the cli cmd * Send telemetry params on rack install and rack params set * CLI docs * Changing approach: The telemetry data will be send by the terraform after all infra will be provisioned * Add resource telemetry on all providers * Extract telemetry for a different module * add telemetry param * Fix unit test * Define a k8s configmap with the values on vars.json. * Get params from configmap and sync with metrics app * Anonymize params * Redact rack_name * refactoring to improve quality on the function to create sync cm * set telemetry var as true as default * Fix deepsource terraform warnings * Fix unit tests * Fix deepsource go warnings * Change telemetry type to boolean * create the configmap just if the settings dir is set (convox#622) * Try to restrict settings variable to only new releases * Fix minor version check for telemetry support * remove prints * rollback go syntax: init toSync map * rollback release version check * Fix deepsource report * Fix unit tests * Remove diff strategy * rack_params as a prefix * Put telemetry off as default for next release * fix unit tests * Fix deepsource * not necessary update sync configmap anymore * Put the right minor version supported * refactoring check if release is supported * try a patch release --------- Co-authored-by: Taynan <Twsouza@users.noreply.github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> Fix internal router (convox#633) Add spot and on_demand instance count in telemetry (convox#621) * Add spot and on_demand instance count in telemetry * Put the login in seperate funtion Fix: fix azure rack install (convox#635) * Azure fix * Fix build security context bug * Update buildkit version Add subnets as variables Change use of `aws_subnet.private` to `var.private_subnets_ids` Add test files Convert params from `map[string]string` to `map[string]interface{}` Revert methods.go Revert pkg/api changes Revert pkg/cli changes Revert pkg/console changes Revert pkg/structs changes Revert pkg/rack changes Add break of interfaces for terraform variables Fix test files Revert cli changes Remove cli test file Change main subnets variable to string, add public subnets Fix subnets of node group Add gateways Fix-821: Local rack fix for minikube (convox#551) * remove hostNetwork config for agents (convox#549) * remove hostNetwork config for agents * Adding CodeOwners to request approve when a PR is open to merge on master * Changes CodeOwners team * update documentation Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Fix for local v3 rack install for minikube * set type of resolver-external as 'ClusterIP' only * Remove the dummy selector * Use public dns resolver to resolve the minikube ip * Add seperate domain for mac --------- Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> Update-821: Dev rack and misc docs Update-821: Dev rack and misc docs-2 Remove nat gateway from locals Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review Revert changes on `pkg/cli/login.go` Revert changes on `pkg/rack/console.go` Remove comments Remove unecessary comment Add compact Fix use of route table when only passing VPC Create rack using existing subnets (convox#563) * Add subnets as variables * Change use of `aws_subnet.private` to `var.private_subnets_ids` * Add test files * Convert params from `map[string]string` to `map[string]interface{}` * Revert methods.go * Revert pkg/api changes * Revert pkg/cli changes * Revert pkg/console changes * Revert pkg/structs changes * Revert pkg/rack changes * Add break of interfaces for terraform variables * Fix test files * Fix-821: Local rack fix for minikube (convox#551) * remove hostNetwork config for agents (convox#549) * remove hostNetwork config for agents * Adding CodeOwners to request approve when a PR is open to merge on master * Changes CodeOwners team * update documentation Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Fix for local v3 rack install for minikube * set type of resolver-external as 'ClusterIP' only * Remove the dummy selector * Use public dns resolver to resolve the minikube ip * Add seperate domain for mac --------- Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> * Update-821: Dev rack and misc docs * Update-821: Dev rack and misc docs-2 * Update-821: Dev rack and misc docs-3 * Revert cli changes * Remove cli test file * Change main subnets variable to string, add public subnets * Fix subnets of node group * Add gateways * Remove nat gateway from locals * Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review * build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0 (convox#575) * Feat-838: Internal router for rack to communication (convox#565) * Add support internal nginx for internal rack to rack communication * Address the doc review * Change dependabot to open PRs to the staging branch (convox#573) * build(deps): bump github.com/creack/pty from 1.1.13 to 1.1.18 (convox#467) Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.13 to 1.1.18. - [Release notes](https://github.com/creack/pty/releases) - [Commits](creack/pty@v1.1.13...v1.1.18) --- updated-dependencies: - dependency-name: github.com/creack/pty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/gorilla/mux from 1.7.3 to 1.8.0 Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.3 to 1.8.0. - [Release notes](https://github.com/gorilla/mux/releases) - [Commits](gorilla/mux@v1.7.3...v1.8.0) --- updated-dependencies: - dependency-name: github.com/gorilla/mux dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Revert changes on `pkg/cli/login.go` * Revert changes on `pkg/rack/console.go` * Remove comments * Remove unecessary comment --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Md. Nure Alam Nahid <knightnahid@gmail.com> Co-authored-by: Yuri Adams Chaves Maia <yuriadams@gmail.com> Co-authored-by: Taynan Souza <taynan.tws@gmail.com> Co-authored-by: Nick <nthoni@hotmail.com> Co-authored-by: Taynan <Twsouza@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Add docs of subnets Change rack name (convox#589) * Add rack_name to the vars It will be used to set the rack name * Add rack name to the nanespace label * Change the rack name before it's moved to the console or locally * Fix tests about terraform * Add rack_name to all providers fix: Add fix for aws gov cloud (convox#609) * Add fix for aws gov cloud * Fix attribute not found error when terraform destroy Remove outdated code and unused lib (convox#611) Set default value for rack_name on tf files Fix rack markdown newline Remove duplicate `wait_for_cluster` Revert unused files Only use rack_name on a supported version (convox#618) * Rack install, move or update will only attach rack_name if it's on a supported version * Fix tests Remove duplicate variables on aws Add `data.aws_nat_gateway`
lucasmacedot
added a commit
to DNXLabs/convox
that referenced
this pull request
Aug 2, 2023
commit 9109117 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Mon Jul 24 17:06:33 2023 +0100 Add force promote or deploy option (convox#672) commit bc097d5 Author: Ed Fricker <888909+beastawakens@users.noreply.github.com> Date: Fri Jul 21 19:43:41 2023 +0100 Allow for different AMI types for build node (convox#669) * Bootstrap read access authorization * Add rack api access access mechanism * Add doc for rack access cmd * Refactor telemetry work (convox#666) * update golang.org/x/text to v0.11.0 * Use plural for duration in hours * set random_id for build node if build node enabled * Allow for different AMI types for build node --------- Co-authored-by: nightfury1204 <knightnahid@gmail.com> commit c9d5271 Author: nightfury1204 <knightnahid@gmail.com> Date: Mon Jul 10 22:54:52 2023 +0100 set random_id for build node if build node enabled commit a3ab575 Author: nightfury1204 <knightnahid@gmail.com> Date: Mon Jul 10 18:22:05 2023 +0100 Use plural for duration in hours commit 2e398c9 Author: nightfury1204 <knightnahid@gmail.com> Date: Mon Jul 10 17:25:36 2023 +0100 update golang.org/x/text to v0.11.0 commit 77ea454 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Mon Jul 10 17:20:05 2023 +0100 Refactor telemetry work (convox#666) commit e73fee7 Author: nightfury1204 <knightnahid@gmail.com> Date: Fri Jun 30 13:00:44 2023 +0100 Add doc for rack access cmd commit 8501073 Author: nightfury1204 <knightnahid@gmail.com> Date: Thu Jun 22 23:15:35 2023 +0100 Add rack api access access mechanism commit cb3ed23 Author: nightfury1204 <knightnahid@gmail.com> Date: Thu Apr 20 14:37:44 2023 +0100 Bootstrap read access authorization commit 1c6972a Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Mon Jun 26 15:39:34 2023 +0100 Add custom label support (convox#658) commit 367e180 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Wed Jun 21 11:25:04 2023 +0100 Feat k8s 1.25 (convox#657) * k8s 1.25 update * Update to go 1.18 * update ebs csi driver * CronJob to batch/v1 * Update do and gcp version * Fix azure dependency on resource group commit cfd1d02 Author: Md. Nure Alam Nahid <knightnahid@gmail.com> Date: Fri Jun 16 20:59:16 2023 +0100 Add grpc support (convox#656)
lucasmacedot
pushed a commit
to DNXLabs/convox
that referenced
this pull request
Aug 2, 2023
lucasmacedot
pushed a commit
to DNXLabs/convox
that referenced
this pull request
Aug 2, 2023
beastawakens
pushed a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
https://app.asana.com/0/1203637156732418/1205074664492413/f
https://app.asana.com/0/1203637156732418/1205074664492419/f
Add screenshot or video (optional)
Does it has a breaking change?
no
How to use/test it?
Checklist