Skip to content

Commit

Permalink
[#3721] Add param to shorten internal router domain to avoid characte…
Browse files Browse the repository at this point in the history
…r limit exceed

### What is the feature/fix?

- When rack name is long, turning on internal router gives domain name character limit exceeded error. Set `InternalRouterSuffix=""` to resolve that error

https://app.asana.com/0/1203637156732418/1205259849182934/f
  • Loading branch information
nightfury1204 committed Mar 13, 2024
1 parent c8bdaf9 commit 46517b8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions provider/aws/formation/rack.json
Expand Up @@ -16,7 +16,7 @@
"BlankInstanceRunCommand": { "Fn::Equals": [ { "Ref": "InstanceRunCommand" }, "" ] },
"BlankInstanceSecurityGroup": { "Fn::Equals": [ {"Ref": "InstanceSecurityGroup" }, "" ] },
"BlankBuildInstanceSecurityGroup": { "Fn::Equals": [ {"Ref": "BuildInstanceSecurityGroup" }, "" ] },
"BlankInternalSuffix": { "Fn::Equals": [ { "Ref": "InternalSuffix"}, "" ] },
"BlankInternalRouterSuffix": { "Fn::Equals": [ { "Ref": "InternalRouterSuffix"}, "" ] },
"BlankInternetGateway": { "Fn::Equals": [ { "Ref": "InternetGateway"}, "" ] },
"BlankKey": { "Fn::Equals": [ { "Ref": "Key" }, "" ] },
"BlankLogBucket": { "Fn::Equals": [ { "Ref": "LogBucket" }, "" ] },
Expand Down Expand Up @@ -757,7 +757,7 @@
"Default": "No",
"AllowedValues": [ "Yes", "No" ]
},
"InternalSuffix": {
"InternalRouterSuffix": {
"Type": "String",
"Description": "Suffix for internal router",
"Default": "-rti"
Expand Down Expand Up @@ -3426,7 +3426,7 @@
{ "Key": "access_logs.s3.prefix", "Value": { "Fn::Sub": "convox/logs/${AWS::StackName}/alb" } },
{ "Key": "idle_timeout.timeout_seconds", "Value": "3600" }
],
"Name": { "Fn::If": [ "BlankInternalSuffix", { "Ref": "AWS::NoValue" }, { "Fn::Sub": "${AWS::StackName}${InternalSuffix}" } ] },
"Name": { "Fn::If": [ "BlankInternalRouterSuffix", {"Fn::Select":[3,{"Fn::Split":["-",{"Fn::Select":[2,{"Fn::Split":["/",{"Ref":"AWS::StackId"}]}]}]}]}, { "Fn::Sub": "${AWS::StackName}${InternalRouterSuffix}" } ] },
"Scheme": "internal",
"Subnets": { "Fn::If": [ "Private",
[
Expand Down
2 changes: 1 addition & 1 deletion provider/aws/telemetry.go
Expand Up @@ -29,7 +29,7 @@ var (
"ClientId",
"ExistingVpc",
"HttpProxy",
"InternalSuffix",
"InternalRouterSuffix",
"InstanceBootCommand",
"InstanceRunCommand",
"InstancePolicy",
Expand Down

0 comments on commit 46517b8

Please sign in to comment.