Add param to shorten internal router domain to avoid character limit exceed #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3721 +/- ##
==========================================
+ Coverage 33.64% 33.67% +0.03%
==========================================
Files 180 180
Lines 20183 20183
==========================================
+ Hits 6790 6797 +7
+ Misses 12247 12239 -8
- Partials 1146 1147 +1 ☔ View full report in Codecov by Sentry. |
nightfury1204
added a commit
that referenced
this pull request
Mar 13, 2024
…r limit exceed ### What is the feature/fix? - When rack name is long, turning on internal router gives domain name character limit exceeded error. Set `InternalRouterSuffix=""` to resolve that error https://app.asana.com/0/1203637156732418/1205259849182934/f
4 tasks
nightfury1204
added a commit
that referenced
this pull request
Mar 13, 2024
…r limit exceed ### What is the feature/fix? - When rack name is long, turning on internal router gives domain name character limit exceeded error. Set `InternalRouterSuffix=""` to resolve that error https://app.asana.com/0/1203637156732418/1205259849182934/f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
When rack names are over 15 characters the Internal Load Balancer feature was unable to be used because of domain length error.
We have updated rack parameter
InternalRouterSuffixto resolve this issue.Does it has a breaking change?
No breaking change
How to use/test it?
Update your rack to the latest version with the command
convox rack update -r rackNameThen to enable the rack's internal load balancer set rack parameters
InternalandInternalRouterSuffixwith commandconvox rack params set Internal=Yes InternalRouterSuffix= -r rackName