error out if link to non existant service or if service doesn't expos… #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 16.51% (diff: 81.48%)@@ master #1001 diff @@
==========================================
Files 137 137
Lines 11521 11548 +27
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1875 1907 +32
+ Misses 9526 9521 -5
Partials 120 120
|
|
Can we add some quick tests around this? |
|
tests added cc @MiguelMoll @ddollar |
awsmsrc
force-pushed
the
dont_link_without_ports
branch
from
3a5c3bb
to
e9c27da
Compare
ddollar
added a commit
that referenced
this pull request
Aug 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e ports
fixes #990
fixes #994