Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont push 5 times #1002

Closed
wants to merge 4 commits into from
Closed

dont push 5 times #1002

wants to merge 4 commits into from

Conversation

awsmsrc
Copy link
Contributor

@awsmsrc awsmsrc commented Aug 8, 2016

this one is one of mine and is slightly embarrassing :(

@awsmsrc
Copy link
Contributor Author

awsmsrc commented Aug 8, 2016

@codecov-io
Copy link

codecov-io commented Aug 8, 2016

Current coverage is 16.66% (diff: 77.77%)

Merging #1002 into master will increase coverage by 0.18%

@@             master      #1002   diff @@
==========================================
  Files           137        137          
  Lines         11390      11390          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1877       1898    +21   
+ Misses         9403       9380    -23   
- Partials        110        112     +2   

Powered by Codecov. Last update ec272e2...7c29c6a

@ddollar
Copy link
Contributor

ddollar commented Aug 8, 2016

Can we add some quick tests around this?

@awsmsrc
Copy link
Contributor Author

awsmsrc commented Aug 8, 2016

@ddollar ddollar added this to the 20160808 milestone Aug 8, 2016
ddollar added a commit that referenced this pull request Aug 8, 2016
@ddollar ddollar mentioned this pull request Aug 8, 2016
13 tasks
@ddollar ddollar closed this in #1006 Aug 8, 2016
@ddollar ddollar deleted the dont_push_5_times branch August 10, 2016 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants