New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better rolling of asgs #107

Merged
merged 5 commits into from Oct 16, 2015

Conversation

Projects
None yet
3 participants
@csquared
Copy link
Contributor

csquared commented Oct 14, 2015

simple first pass

  • wait for resource signals, 15m timeout
  • send signals after cfn-init completes

note: does not wait for ecs-agent or convox start to finish.

@csquared

This comment has been minimized.

Copy link
Contributor

csquared commented Oct 15, 2015

@@ -551,7 +554,9 @@
"UpdatePolicy": {
"AutoScalingRollingUpdate": {
"MaxBatchSize": 1,
"MinInstancesInService": 1
"MinInstancesInService": 1,
"PauseTime" : "PT15M",

This comment has been minimized.

@ddollar

ddollar Oct 16, 2015

Member

Does it roll faster than this if it receives the signal?

This comment has been minimized.

@csquared

csquared Oct 16, 2015

Contributor

Yes that's just a timeout for receiving all the signals. We could even bump it to 20 or 30

On Oct 16, 2015, at 8:13 AM, David Dollar notifications@github.com wrote:

In api/dist/kernel.json:

@@ -551,7 +554,9 @@
"UpdatePolicy": {
"AutoScalingRollingUpdate": {
"MaxBatchSize": 1,

  •      "MinInstancesInService": 1
    
  •      "MinInstancesInService": 1,
    
  •      "PauseTime" : "PT15M",
    
    Does it roll faster than this if it receives the signal?


Reply to this email directly or view it on GitHub.

@nzoschke

This comment has been minimized.

Copy link
Contributor

nzoschke commented Oct 16, 2015

👍

csquared added a commit that referenced this pull request Oct 16, 2015

Merge pull request #107 from convox/better-rack-rollover
wait for resource signals, 15m timeout
send signals after cfn-init completes
note: does not wait for ecs-agent or convox start to finish.

@csquared csquared merged commit f5620e8 into master Oct 16, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 60.501%
Details

@csquared csquared deleted the better-rack-rollover branch Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment