Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better rolling of asgs #107

Merged
merged 5 commits into from
Oct 16, 2015
Merged

better rolling of asgs #107

merged 5 commits into from
Oct 16, 2015

Conversation

csquared
Copy link
Contributor

simple first pass

  • wait for resource signals, 15m timeout
  • send signals after cfn-init completes

note: does not wait for ecs-agent or convox start to finish.

@csquared
Copy link
Contributor Author

@@ -551,7 +554,9 @@
"UpdatePolicy": {
"AutoScalingRollingUpdate": {
"MaxBatchSize": 1,
"MinInstancesInService": 1
"MinInstancesInService": 1,
"PauseTime" : "PT15M",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it roll faster than this if it receives the signal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's just a timeout for receiving all the signals. We could even bump it to 20 or 30

On Oct 16, 2015, at 8:13 AM, David Dollar notifications@github.com wrote:

In api/dist/kernel.json:

@@ -551,7 +554,9 @@
"UpdatePolicy": {
"AutoScalingRollingUpdate": {
"MaxBatchSize": 1,

  •      "MinInstancesInService": 1
    
  •      "MinInstancesInService": 1,
    
  •      "PauseTime" : "PT15M",
    
    Does it roll faster than this if it receives the signal?


Reply to this email directly or view it on GitHub.

@nzoschke
Copy link
Contributor

👍

csquared added a commit that referenced this pull request Oct 16, 2015
wait for resource signals, 15m timeout
send signals after cfn-init completes
note: does not wait for ecs-agent or convox start to finish.
@csquared csquared merged commit f5620e8 into master Oct 16, 2015
@csquared csquared deleted the better-rack-rollover branch October 16, 2015 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants