Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better rolling of asgs #107

Merged
merged 5 commits into from
Oct 16, 2015
Merged

better rolling of asgs #107

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30ed206
try rollover with cfn-signals by waiting on resource signals
csquared Oct 14, 2015
2ebbcb1
give it fifteen minutes, warning: magic constant
csquared Oct 14, 2015
2f233ed
install cfn via aws-cfn-bootstrap
csquared Oct 15, 2015
e81a789
have to pass a value
csquared Oct 15, 2015
125185a
defaults to true
csquared Oct 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion api/dist/kernel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@
"#!/bin/bash",
"fallocate -l 5G /swapfile && chmod 0600 /swapfile && mkswap /swapfile && swapon /swapfile",
"yum -y update",
"yum -y install aws-cfn-bootstrap",
{ "Fn::Join": [ "", [ "echo ECS_CLUSTER=", { "Ref": "Cluster" }, " >> /etc/ecs/ecs.config" ] ] },
"echo ECS_ENGINE_AUTH_TYPE=docker >> /etc/ecs/ecs.config",
{ "Fn::If": [ "BlankCertificate",
Expand All @@ -508,6 +509,8 @@
"mkdir -p /etc/convox",
{ "Fn::Join": [ "", [ "echo \"", { "Ref": "AWS::Region" }, "\" > /etc/convox/region" ] ] },
"curl -s http://convox.s3.amazonaws.com/agent/0.3/convox.conf > /etc/init/convox.conf",
{ "Fn::Join": [ " ", [ "/opt/aws/bin/cfn-init", "-s", { "Ref": "AWS::StackName" }, "-r", "Instances", "--region", {"Ref":"AWS::Region"} ] ] },
{ "Fn::Join": [ " ", [ "/opt/aws/bin/cfn-signal", "--stack", { "Ref": "AWS::StackName" }, "--resource", "Instances", "--region", {"Ref":"AWS::Region"} ] ] },
"start convox"
] ] }
}
Expand Down Expand Up @@ -551,7 +554,9 @@
"UpdatePolicy": {
"AutoScalingRollingUpdate": {
"MaxBatchSize": 1,
"MinInstancesInService": 1
"MinInstancesInService": 1,
"PauseTime" : "PT15M",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it roll faster than this if it receives the signal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's just a timeout for receiving all the signals. We could even bump it to 20 or 30

On Oct 16, 2015, at 8:13 AM, David Dollar notifications@github.com wrote:

In api/dist/kernel.json:

@@ -551,7 +554,9 @@
"UpdatePolicy": {
"AutoScalingRollingUpdate": {
"MaxBatchSize": 1,

  •      "MinInstancesInService": 1

  •      "MinInstancesInService": 1,

  •      "PauseTime" : "PT15M",
    Does it roll faster than this if it receives the signal?

—
Reply to this email directly or view it on GitHub.

"WaitOnResourceSignals": "true"
}
}
},
Expand Down