-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse certs #1402
Reuse certs #1402
Conversation
Current coverage is 29.04% (diff: 0.00%)@@ master #1402 diff @@
==========================================
Files 137 137
Lines 12900 12923 +23
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3752 3753 +1
- Misses 8750 8772 +22
Partials 398 398
|
|
||
app.Parameters[certParam] = *res.ServerCertificateMetadata.Arn | ||
|
||
time.Sleep(45 * time.Second) // delay to let cert propagate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sleep a test or do we really want something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a test, but based on the AWS ticket.
We observed certs created 30s before the CF stack creation that couldn't be used.
So the hypothesis is that adding a sleep will help with IAM delay and let the first deploy work more reliably.
But we also have evidence that this may have been a transient error so maybe we don't need it.
…create one with a generous delay
2445701
to
5c05c85
Compare
5c05c85
to
b73da58
Compare
👍 |
Demo