allow convox-env to pass through signals #2465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, thanks! |
ddollar
reviewed
Jan 25, 2018
cmd/convox-env/main.go
Outdated
| fmt.Fprintf(os.Stderr, "ERROR: %s\n", err) | ||
| os.Exit(1) | ||
| } | ||
|
|
||
| os.Exit(0) |
There was a problem hiding this comment.
nope, it should just exit cleanly if it gets to this point. good call, will remove
|
Had to make a quick tweak to |
|
Here's the conflicting PR for reference: #2467 |
|
@ddollar updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
convox-envforward signals correctly to the wrapped command. Without this, if ECS sends aSIGTERMto your container,convox-envwould get the signal but wouldn't give it to theCMD, which means that your application wouldn't be able to gracefully shutdown.I'm still fairly new to golang, so any and all feedback would be appreciated!