Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more validations for api endpoints #2925

Closed
wants to merge 3 commits into from
Closed

more validations for api endpoints #2925

wants to merge 3 commits into from

Conversation

ddollar
Copy link
Contributor

@ddollar ddollar commented Sep 7, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #2925 into master will increase coverage by 0.07%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
+ Coverage   31.16%   31.23%   +0.07%     
==========================================
  Files         219      219              
  Lines       20301    20316      +15     
==========================================
+ Hits         6326     6345      +19     
+ Misses      12597    12595       -2     
+ Partials     1378     1376       -2
Impacted Files Coverage Δ
pkg/api/validation.go 90.9% <86.66%> (-9.1%) ⬇️
pkg/api/controllers.go 63.84% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb3390...9e24f5b. Read the comment docs.

@ddollar ddollar changed the title add validation to release promote more validations for api endpoints Sep 7, 2018
@ddollar ddollar added this to the 20180907 milestone Sep 7, 2018
ddollar added a commit that referenced this pull request Sep 7, 2018
@ddollar ddollar mentioned this pull request Sep 7, 2018
15 tasks
ddollar added a commit that referenced this pull request Sep 7, 2018
@ddollar ddollar closed this in #2928 Sep 7, 2018
@ddollar ddollar deleted the validation branch September 9, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant