Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 20230308 #3653

Closed
wants to merge 2 commits into from
Closed

[RELEASE] 20230308 #3653

wants to merge 2 commits into from

Conversation

nightfury1204
Copy link
Collaborator

@nightfury1204 nightfury1204 commented Mar 8, 2023

Pull Requests

Milestone Release

  • Release branch: 20230315094328-20230308
  • Pass CI
  • Merge into master
  • Close milestone
  • Release master
  • Record release number:
  • Pass CI
  • Write release notes
  • Documentation review
  • Publish release

### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204034868203010/f

### Add screenshot or video (optional)

### Does it has a breaking change?

no

### How to use/test it?

- update rack to newest version
- we can enter into a instance to check if the agent process is running.
- check metrics collected in cloudwatch

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204034844054250/f

### Add screenshot or video (optional)

### Does it has a breaking change?

no

### How to use/test it?

- deploy the console: convox/console#312
- then deploy rack and try the cli

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 13.55% and project coverage change: -0.11 ⚠️

Comparison is base (5b5011c) 36.01% compared to head (a492ba5) 35.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3653      +/-   ##
==========================================
- Coverage   36.01%   35.90%   -0.11%     
==========================================
  Files         168      168              
  Lines       18585    18644      +59     
==========================================
+ Hits         6694     6695       +1     
- Misses      10751    10810      +59     
+ Partials     1140     1139       -1     
Impacted Files Coverage Δ
sdk/methods.go 76.52% <0.00%> (-1.95%) ⬇️
pkg/cli/rack.go 58.20% <17.39%> (-6.50%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Twsouza Twsouza closed this Mar 21, 2023
@nightfury1204 nightfury1204 deleted the 20230308 branch August 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants