Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for rack access #3664

Closed
wants to merge 2 commits into from

Conversation

nightfury1204
Copy link
Collaborator

What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204402996040452/f

Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

How to use/test it?

** Describe how to test or use the feature **

Checklist

  • New coverage tests
  • Unit tests passing
  • E2E tests passing
  • E2E downgrade/update test passing
  • Documentation updated
  • No warnings or errors on Deepsource/Codecov

Copy link
Contributor

@Twsouza Twsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just small changes

pkg/api/authorization.go Outdated Show resolved Hide resolved
pkg/api/authorization.go Show resolved Hide resolved
@nightfury1204 nightfury1204 marked this pull request as draft June 5, 2023 14:49
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 38.72% and project coverage change: +0.02 🎉

Comparison is base (fcb6894) 35.78% compared to head (27f6fc6) 35.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
+ Coverage   35.78%   35.81%   +0.02%     
==========================================
  Files         169      171       +2     
  Lines       18719    18921     +202     
==========================================
+ Hits         6699     6776      +77     
- Misses      10882    11001     +119     
- Partials     1138     1144       +6     
Impacted Files Coverage Δ
pkg/api/controllers.go 60.83% <0.00%> (-1.78%) ⬇️
provider/aws/aws.go 22.64% <0.00%> (-0.55%) ⬇️
provider/k8s/system.go 0.00% <0.00%> (ø)
sdk/methods.go 73.84% <0.00%> (-2.68%) ⬇️
provider/aws/system.go 28.65% <2.94%> (-1.80%) ⬇️
pkg/cli/rack.go 55.94% <34.28%> (-2.27%) ⬇️
pkg/api/api.go 67.34% <50.00%> (-8.33%) ⬇️
pkg/jwt/jwt.go 76.74% <76.74%> (ø)
pkg/api/authorization.go 95.83% <95.83%> (ø)
pkg/api/routes.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightfury1204 nightfury1204 marked this pull request as ready for review June 30, 2023 14:03
@nightfury1204 nightfury1204 changed the title Bootstrap role access authorization basic Feat: Add support for rack access Jun 30, 2023
nightfury1204 added a commit that referenced this pull request Jul 3, 2023
### What is the feature/fix?
https://app.asana.com/0/1203637156732418/1204402996040452/f

### Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

### Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

### How to use/test it?

** Describe how to test or use the feature **

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@nightfury1204 nightfury1204 mentioned this pull request Jul 3, 2023
4 tasks
nightfury1204 added a commit that referenced this pull request Jul 4, 2023
### What is the feature/fix?
https://app.asana.com/0/1203637156732418/1204402996040452/f

### Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

### Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

### How to use/test it?

** Describe how to test or use the feature **

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@nightfury1204 nightfury1204 deleted the feat-role-authorization-basic branch July 10, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants