New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for rack access #3664
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twsouza
reviewed
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just small changes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3664 +/- ##
==========================================
+ Coverage 35.78% 35.81% +0.02%
==========================================
Files 169 171 +2
Lines 18719 18921 +202
==========================================
+ Hits 6699 6776 +77
- Misses 10882 11001 +119
- Partials 1138 1144 +6
☔ View full report in Codecov by Sentry. |
nightfury1204
force-pushed
the
feat-role-authorization-basic
branch
from
June 27, 2023 16:01
cc142f9
to
dcef21c
Compare
nightfury1204
force-pushed
the
feat-role-authorization-basic
branch
from
June 30, 2023 12:18
dcef21c
to
27f6fc6
Compare
nightfury1204
changed the title
Bootstrap role access authorization basic
Feat: Add support for rack access
Jun 30, 2023
nightfury1204
added a commit
that referenced
this pull request
Jul 3, 2023
### What is the feature/fix? https://app.asana.com/0/1203637156732418/1204402996040452/f ### Add screenshot or video (optional) ** Any screenshot or video capture using the feature ** ### Does it has a breaking change? ** Describe the changes and if it has any breaking changes in any feature ** ### How to use/test it? ** Describe how to test or use the feature ** ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
nightfury1204
added a commit
that referenced
this pull request
Jul 4, 2023
### What is the feature/fix? https://app.asana.com/0/1203637156732418/1204402996040452/f ### Add screenshot or video (optional) ** Any screenshot or video capture using the feature ** ### Does it has a breaking change? ** Describe the changes and if it has any breaking changes in any feature ** ### How to use/test it? ** Describe how to test or use the feature ** ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
https://app.asana.com/0/1203637156732418/1204402996040452/f
Add screenshot or video (optional)
** Any screenshot or video capture using the feature **
Does it has a breaking change?
** Describe the changes and if it has any breaking changes in any feature **
How to use/test it?
** Describe how to test or use the feature **
Checklist