[RELEASE] 20230703154154 #3689
Merged
[RELEASE] 20230703154154 #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What is the feature/fix? https://app.asana.com/0/1203637156732418/1204875717950149/f ### Add screenshot or video (optional) ** Any screenshot or video capture using the feature ** ### Does it has a breaking change? ** Describe the changes and if it has any breaking changes in any feature ** ### How to use/test it? - you need cli and rack of this version ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
### What is the feature/fix? Create a role that will use the defined policies on that service. It overrides the [IamPolicy](https://docsv2.convox.com/reference/app-parameters#iampolicy) just for that service (it will not be used if `policies` is defined on convox.yml`). Priority: 1. DedicatedRole (at service level, if specified) 2. IamPolicy ### Does it has a breaking change? No, current ServiceRoles are not affected by the change. ### How to use/test it? - Create a rack with the RC installed. - Deploy an app with the following yml: ``` services: web: policies: - arn:aws:iam::aws:policy/AdministratorAccess build: . port: 3000 api: build: . port: 3000 ``` - Check on IAM if the policies were created correctly. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
### What is the feature/fix? https://app.asana.com/0/1203637156732418/1204402996040452/f ### Add screenshot or video (optional) ** Any screenshot or video capture using the feature ** ### Does it has a breaking change? ** Describe the changes and if it has any breaking changes in any feature ** ### How to use/test it? ** Describe how to test or use the feature ** ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3689 +/- ##
==========================================
+ Coverage 35.78% 35.82% +0.03%
==========================================
Files 169 171 +2
Lines 18719 18933 +214
==========================================
+ Hits 6699 6783 +84
- Misses 10882 11006 +124
- Partials 1138 1144 +6
☔ View full report in Codecov by Sentry. |
ntner
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
-
Install and update to rack version
-
Downgrade to previous version
-
Telemetry based param groupings at install
-
Common convox rack param set variations after install
-
New application install and running with multiple resources
-
Existing application working after upgrade
-
Review and Deploy Workflows working across update
-
General and build stress-testing
-
Service level policy, multiple variations tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
Milestone Release
20230703181840-dev