Specify policies to be used by each service #3687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twsouza
force-pushed
the
feat-service-yaml
branch
from
1ae5325
to
82ac644
Compare
nightfury1204
added a commit
that referenced
this pull request
Jul 3, 2023
### What is the feature/fix? Create a role that will use the defined policies on that service. It overrides the [IamPolicy](https://docsv2.convox.com/reference/app-parameters#iampolicy) just for that service (it will not be used if `policies` is defined on convox.yml`). Priority: 1. DedicatedRole (at service level, if specified) 2. IamPolicy ### Does it has a breaking change? No, current ServiceRoles are not affected by the change. ### How to use/test it? - Create a rack with the RC installed. - Deploy an app with the following yml: ``` services: web: policies: - arn:aws:iam::aws:policy/AdministratorAccess build: . port: 3000 api: build: . port: 3000 ``` - Check on IAM if the policies were created correctly. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
nightfury1204
added a commit
that referenced
this pull request
Jul 4, 2023
### What is the feature/fix? Create a role that will use the defined policies on that service. It overrides the [IamPolicy](https://docsv2.convox.com/reference/app-parameters#iampolicy) just for that service (it will not be used if `policies` is defined on convox.yml`). Priority: 1. DedicatedRole (at service level, if specified) 2. IamPolicy ### Does it has a breaking change? No, current ServiceRoles are not affected by the change. ### How to use/test it? - Create a rack with the RC installed. - Deploy an app with the following yml: ``` services: web: policies: - arn:aws:iam::aws:policy/AdministratorAccess build: . port: 3000 api: build: . port: 3000 ``` - Check on IAM if the policies were created correctly. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Create a role that will use the defined policies on that service. It overrides the IamPolicy just for that service (it will not be used if
policiesis defined on convox.yml`).Priority:
Does it has a breaking change?
No, current ServiceRoles are not affected by the change.
How to use/test it?
Checklist