Add parameter to place Convox managed Lambdas in VPC for private racks #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3716 +/- ##
==========================================
- Coverage 33.68% 33.64% -0.05%
==========================================
Files 180 180
Lines 20179 20183 +4
==========================================
- Hits 6797 6790 -7
- Misses 12235 12247 +12
+ Partials 1147 1146 -1 ☔ View full report in Codecov by Sentry. |
nightfury1204
added a commit
that referenced
this pull request
Feb 5, 2024
…or security requirements ### What is the feature/fix? Add option to put convox lambda's in vpc if rack is private for security requirements issue: https://app.asana.com/0/1203637156732418/1206477197857608/f ### Does it has a breaking change? no ### How to use/test it? If rack is private, then the set the rack param to Yes: `PlaceLambdaInVpc` ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
nightfury1204
added a commit
that referenced
this pull request
Feb 6, 2024
…or security requirements ### What is the feature/fix? Add option to put convox lambda's in vpc if rack is private for security requirements issue: https://app.asana.com/0/1203637156732418/1206477197857608/f ### Does it has a breaking change? no ### How to use/test it? If rack is private, then the set the rack param to Yes: `PlaceLambdaInVpc` ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
ntner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
We've added a rack new parameter
PlaceLambdaInVpcthat will place Convox managed Lambda functions inside of a VPC forPrivate=Yesracks.Does it has a breaking change?
No breaking change
How to use/test it?
Update your rack to the latest version with the command
convox rack update -r rackNameThen set the rack parameter with the command
convox rack params set PlaceLambdaInVpc=Yes -r rackNameto update and move the Lambda functions inside of the private rack's VPC.