Removed app specific unique params when importing/exporting to avoid error #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 33.17% 33.15% -0.02%
==========================================
Files 183 183
Lines 20553 20556 +3
==========================================
- Hits 6818 6816 -2
- Misses 12585 12591 +6
+ Partials 1150 1149 -1 ☔ View full report in Codecov by Sentry. |
nightfury1204
changed the title
nightfury1204
approved these changes
Aug 7, 2024
nightfury1204
added a commit
that referenced
this pull request
Aug 8, 2024
…o avoid error ### What is the feature/fix? Encountered error where some app parameters which are unique to every app, were being copied while doing app import, this caused failure in copying app parameters while using `convox apps import` . To resolve this before importing app parameters, we are removing the unique parameters.
nightfury1204
added a commit
that referenced
this pull request
Aug 9, 2024
…o avoid error ### What is the feature/fix? Encountered error where some app parameters which are unique to every app, were being copied while doing app import, this caused failure in copying app parameters while using `convox apps import` . To resolve this before importing app parameters, we are removing the unique parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Fix: Prevent Unique App Parameters from Being Copied During
convox apps importWe have fixed an issue where unique app parameters were incorrectly copied during the
convox apps importprocess, causing import failures. This update now removes these unique parameters before the import, ensuring a smoother and error-free process.Why is this important?
This fix ensures that app-specific parameters remain unique during imports, avoiding configuration conflicts and preserving the integrity of each application's settings. This is particularly useful when migrating applications between environments, performing backup and restore operations, or cloning applications for development and testing purposes.
Does it have a breaking change?
There are no breaking changes introduced with this fix.
How to use/test it?
Update your rack to the latest version (20240809110958 or later):
Export and Import your app using the updated commands:
Requirements
To use this fix, you must be on at least rack version
20240809110958.You can check your rack's version with the command
convox rack -r rackName.Update your rack to the latest version with the command
convox rack update -r rackName.