Use current active release to fork from #803
Conversation
| @@ -144,6 +144,11 @@ func (p *TestProviderRunner) ReleaseList(app string) (structs.Releases, error) { | |||
| return p.Releases, nil | |||
| } | |||
|
|
|||
| func (p *TestProviderRunner) ReleaseLatest(app string) (*structs.Release, error) { | |||
There was a problem hiding this comment.
exported method TestProviderRunner.ReleaseLatest should have comment or be unexported
|
The refactor looks great. I'd like to start getting a bit more prescriptive about including tests with patches. I think provider interface work is the obvious place to start since the TestProvider is there to offer easier testing strategies. Want to include some tests with this PR? |
|
Sure that sounds good to me. Also some output: |
|
Noah brought up:
|
MiguelMoll
changed the title
|
I think the app's "current environment" is separate from the releases. We can pull the current environment from S3 rather than the latest or current release. |
| @@ -19,3 +19,11 @@ func NewRelease(app string) *Release { | |||
| Id: generateId("R", 10), | |||
| } | |||
| } | |||
|
|
|||
| func (rs Releases) Latest() *Release { | |||
There was a problem hiding this comment.
exported method Releases.Latest should have comment or be unexported
There was a problem hiding this comment.
This could be susceptible to bugs in the future. There's no guarantee that this Releases struct is sorted appropriately.
There was a problem hiding this comment.
Makes sense. Safer to check Created to get the latest one.
- Ported environment features to the provider interface and new Environment type.
MiguelMoll
force-pushed
the
fork-release-fix
branch
from
61964a6
to
861aea3
Compare
| return names | ||
| } | ||
|
|
||
| func (e Environment) Raw() string { |
There was a problem hiding this comment.
exported method Environment.Raw should have comment or be unexported
Release created by environment change uses unexpected build
MiguelMoll
changed the title
release
If no releaseId is provided, `convox run` will use the last promoted release to run a
process. Otherwise iterate over the previous revisions (starting with the
latest) looking for the releaseId specified. This makes sure the same
environment variables are available.
This does not resolve the issue where `convox run` can be used with a
release that hasn't been promoted yet. That will be tackled separately.
Closes #669
|
|
||
| ea := make([]string, 0) |
There was a problem hiding this comment.
can probably use "var ea []string" instead
| break | ||
| // If no releaseId is provided, use the last promoted release to run this process | ||
| // otherwise iterate over the previous revisions (starting with the latest) looking for the releaseId specified. | ||
| if releaseId == "" { |
There was a problem hiding this comment.
looks good to me to retain the current run behavior with no release specified
|
Merged via #820 |
Whenever
ForkReleaseis called it will now use the current release's build. Fixes #793Also moved
ReleaseLatestto the provider interface and added the Build ID to the output ofconvox releases.Also in here, is a fix for
convox run --release. If no releaseId is provided,convox runwill use the last promoted release to run a process. Otherwise iterate over the previous revisions (starting with thelatest) looking for the releaseId specified. This makes sure the same environment variables are available. Closes #669
This does not resolve the issue where
convox runcan be used with arelease that hasn't been promoted yet. That will be tackled separately.