Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad the uploading progress message to clear some text #890

Closed
wants to merge 1 commit into from

Conversation

MiguelMoll
Copy link
Contributor

@MiguelMoll MiguelMoll commented Jul 20, 2016

This approach seems the most pragmatic. Other option is to mess around with ASCII/Unicode escape characters to clear the end of the line:

fmt.Printf("\r\033[KUploading... %s       ", strings.TrimSpace(s))

It works but could run into issues with a different character encoding.

@ddollar ddollar added this to the 20160720 milestone Jul 20, 2016
ddollar added a commit that referenced this pull request Jul 20, 2016
@ddollar ddollar mentioned this pull request Jul 20, 2016
14 tasks
@codecov-io
Copy link

codecov-io commented Jul 20, 2016

Current coverage is 17.07%

Merging #890 into master will not change coverage

@@             master       #890   diff @@
==========================================
  Files           138        138          
  Lines         12594      12594          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2150       2150          
  Misses        10298      10298          
  Partials        146        146          

Powered by Codecov. Last updated by 5ae432d...4c21c98

ddollar added a commit that referenced this pull request Jul 20, 2016
@ddollar
Copy link
Contributor

ddollar commented Jul 20, 2016

Merged in #891

@ddollar ddollar closed this Jul 20, 2016
@ddollar ddollar deleted the upload-status branch July 20, 2016 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants