New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] 20160720 #891
Merged
[RELEASE] 20160720 #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 16.76%@@ master #891 diff @@
==========================================
Files 138 138
Lines 12594 12710 +116
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2150 2131 -19
- Misses 10298 10433 +135
Partials 146 146
|
The idea here is to combine settings from the most recently *promoted* release and the most recently *created* release.
With the logic abstracted, both run methods can use the same steps to determine if a release has been promoted or not and act accordingly.
This includes renaming the `releaseID` variable throught the code to use a capital D.
clean up existing subnet parameters
This was referenced Jul 20, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
convox run
with releases that have yet to be promoted #860 Logic to supportconvox run
with releases that have yet to be promoted [@MiguelMoll]Milestone Release