ckanext- right-time-context cannot communicate with orion in same-domain #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the query API was entered in the following form as shown below on CKAN, the result was not displayed 1) /v1/queryContext 2) /v1/contextEntities Orion can handle both uppercase and lowercase letters(queryContext, contextEntities), but NGSI view can handle in lowercase letters only. NGSI view compares API names in all lowercase letters(querycontext, contextentities). Also,in else part of function "setup_template_variables" - self.get_proxified_ngsi_url(data_dict) is called only in the case of different-domain and does not works properly in case of same-domain.
When the query API was entered in the following form as shown below on CKAN, the result was not displayed 1) /v1/queryContext 2) /v1/contextEntities Orion can handle both uppercase and lowercase letters(queryContext, contextEntities), but NGSI view can handle in lowercase letters only. NGSI view compares API names in all lowercase letters(querycontext, contextentities).
When the query API was entered in the following form as shown below on CKAN, the result was not displayed 1) /v1/queryContext 2) /v1/contextEntities Orion can handle both uppercase and lowercase letters(queryContext, contextEntities), but NGSI view can handle in lowercase letters only. NGSI view compares API names in all lowercase letters(querycontext, contextentities).
Pull Request Test Coverage Report for Build 85
💛 - Coveralls |
aarranz
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Hi @iamarnavgarg,
LGTM, so thanks you very much for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the orion query API was entered in the following form as shown below on CKAN, the result was not displayed for it.
In orion,ngsi can handle both uppercase and lowercase letters(queryContext, contextEntities), but NGSI view can handle in lowercase letters only.
And,NGSI view compares API names in all lowercase letters(querycontext, contextentities).
Secondly,in plugin.py
"setup_template_variables"methodself.get_proxified_ngsi_url(data_dict)is called only in the case of different-domain and does not works properly in case of same-domain. Thus, I have provided a fix for it.