Remove same domain checks #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarranz
force-pushed
the
fix/require-resource-proxy
branch
from
492b7b4
to
52db8e7
Compare
…xy extension also when connecting to the same domain as CKAN
aarranz
force-pushed
the
fix/require-resource-proxy
branch
from
52db8e7
to
0278eb2
Compare
Pull Request Test Coverage Report for Build 95
💛 - Coveralls |
aarranz
force-pushed
the
fix/require-resource-proxy
branch
2 times, most recently
from
a073250
to
536ad2b
Compare
aarranz
force-pushed
the
fix/require-resource-proxy
branch
from
536ad2b
to
d70419c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR removes same domain checks as now the plugin requires the
resource_proxyextension also when connecting to the same domain as the CKAN instance. See #8 for more details.I'm working also to add new tests cases to stress the paths involved in this change.