-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with Firefox's privacy.firstparty.isolate = true #75
Comments
I used that setting before with C-AD months ago, so I'm pretty sure this is a browser bug and Mozilla has to fix it. I'll do some more testing before marking as wontfix/cantfix. |
Yep, that setting sure breaks C-AD and this error might be related since its the only one that appears.
So it seems to be a problem with the WebExtension Cookie API with that setting. |
Upstream Bug 1381197. |
@nkestrel Hmm isn't the problem (at least for C-AD primary functionally) is browser.cookies.remove() doesn't work? Related code: |
I broadened the scope of the bug title, I just found cookies.getAll easier to categorize the failure. |
In fact, I was looking to replace these addons :
But (the addon) CAD (CookieAutoDelete_v 1.4.1) doesn't have these functions (at least not for the moment). And it doesn't seem to work fine...
|
@WagnerGMD Try the troubleshooting steps I posted on the addon page, otherwise make another issue. |
@WagnerGMD Are you in Private Browsing Mode? |
On the moment, I didn't notice the troubleshooting.
But no nothing has changed once I had reset these settings. And I don't think it cause by the profil (from scratch a few times and yes I had restart the browser). No @Thorin-Oakenpants I don't use it often. Just to confirm, yes Clear Console is able to remove them (the cookies). And thank you @bendover22 (for the discovery). |
I can confirm in Fx 54.0.1 Linux, if pref("privacy.firstparty.isolate" = true), then C-AD's toolbar icon shows 0 cookies, when cookies are set. They also don't get deleted when C-AD says. An odd thing, C-AD popup showing how many cookies / which domains were deleted, appeared every so often, even when no tabs had been closed recently. Is that expected? |
Can you double check that @bendover22 , because |
I've tried it for FF54 and FF57 Nightly with both EDIT: Setting |
Is SDC affected by |
Just tried SDC, and it seems that it is affected, too. In other words this is not necessarily a webextension related problem. |
I didn't understand on the moment... So I just will add one reminder : SDC is aka (or the acronyme for) Self-Destructing Cookies. I had stop to use it a few months ago because it doesn't work anymore with the latest release of Firefox...
|
Sorry, no. I had to remove C-AD because it allows all sites to set 1st party cookies. FWIW, I understand they're different, legacy addons vs. C-AD, but in Fx 55 with both of these prefs - "privacy.firstparty..." ** set = true**, both Cookie Monster 1.3.4.8 & Clear Console 1.13 (by Rejah Rehim) delete cookies just fine. I haven't compared cookie handling methods between these 3 addons, Maybe it's just a problem w/ new Moz cookie APIs. But since Mozilla "based cookie API on Chrome's API," you'd think most bugs would be worked out. Or not. If Kenny wants me to test out some C-AD changes later (in Fx, Fx ESR, or Tor Browser), I'll be happy to help. I'd probably create a clean profile for testing purposes. It's possible some other addon gave me different results w/ "privacy.firstparty.isolate.restrict_opener_access" than Thorin, but it's kind of a moot point for me. At least until C-AD can immediately delete cookies (or block), WHEN no cookie exception is stored for a site. If that's not possible or "won't fix," like others are saying - when Fx 57 breaks all legacy addons, I'll probably use an Fx fork that supports them. Possible that Mozilla poo-pooed in their nest, deciding NOT to allow existing legacy addons to work & just require new ones to use web ext. (when almost NO web ext. replacements are ready). Since Netscape, millions of users never wanted 1st party cookies allowed by default. It's more of an issue today, because of sites sharing data w/ 3rd parties (not just cookies), and because many sites are owned by the same entity. Re: https://bugzilla.mozilla.org/show_bug.cgi?id=1319773#c46 - says:
Both prefs are not Tor Browser defaults [not recently]. |
It's possible that Cookie Monster is going through the
Chrome doesn't have first party isolation, so it's pretty much a new case for Mozilla. |
@mrdokenny |
@Thorin-Oakenpants Good to hear.
Seems like Chrome gives access to PB cookies |
So, OK, this happens fundamentally because of a firefox bug. Is it possible to add a test routine, like picking a cookie before it is deleted, and checking after deletion whether it is still present? If the cookie is still present, the extension could warn the user that at least something is wrong (with some RTFM link) instead of poping up "cookies deleted", or at least after poping it out. This would give the user a chance to notice things are wrong. And it would help detect other future similar occurrences of the same problem. The current state of things, with this firefox bug, is that the user believes to be safe, and isn't. Worst possible state. My last sentence needs to be : thanks for this great extension. |
Should I just disable |
I added the fixes necessary for FPI to work in CAD 2.1.0b3 and the latest nightly 59+. When flipping the FPI setting in The https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/privacy/websites Feedback is welcome as there is so many interactions between different browser settings and CAD settings that it's impossible to test for everything. |
Hi @mrdokenny, thank you for your quick work, it's really appreciated! I'm running into a problem when trying to delete cookies in FPI. I've tried flipping the FPI flag on/off, restarting, uninstalling and reinstalling CAD. When trying to delete a cookie, I get this message via the debugging console:
I seem to have this same problem in a new profile. Browser Version: 59.0a1 (2018-01-06) (64-bit) Let me know if there's anything I can do to help diagnose the issue or if there's more info I can provide. Thanks again |
I forgot to add that for the I'll look into it more. Edit: Also sometimes the cookie manager in FF doesn't update right away. So are you still seeing notifications that it gets deleted? |
Ah, perfect! That is working for me.
I'm not seeing notifications in the first case where the error came up, however I do get them when using the cookie clean up |
OK, did a brief testing in FF59b3 and it seems to be working. When pfi = true is set then CAD does delete cookies (& notifies you) you eg. when closing a Tab |
I have received the same error message than @overdodactyl : My question is :
Thank you very much for your kind reply. |
@prog-amateur The point is that FPI=true will prevent any extension from cleaning cookies. So even with Temporary Containers, they won't get deleted based off this comment. |
Also in the new version 2.1.1, CAD will show notifications telling you if you have FPI on only if you have FF 58 since the setting to access the value of FPI is in 58+. |
Thank you very much for your quick feedback, in that case, I have disabled FPI. |
Yes. |
Sorry guys but to be clear, after 58 means 59 and not after 58 is out. Right ? |
Works just flawlessly for me with 59b3 without any containers and with |
For me cookies are not deleted, if firstparty.isolate is true in Firefox 59.0beta4 |
@jmozmoz Try deleting your cookies and restarting your browser. |
Thank you, this worked. |
Hi I have the same issue with Android version 58.0.2, I have a notification to turn off FPI despite deletingcookiesand restart. Please, could you check ? |
@prog-amateur |
@cherti : OK I see, thank you very much for your feedback ! |
Closing as Firefox 59 is out. |
Firefox 59 is out and the issue is fixed. Removed the notification to reduce the clutter. Cookie-AutoDelete/Cookie-AutoDelete#75
With
privacy.firstparty.isolate = true
the cookie count is always zero and cookies are not deleted despite notification claiming that they were.Details about the setting:
https://bugzilla.mozilla.org/show_bug.cgi?id=565965
https://www.torproject.org/projects/torbrowser/design/#identifier-linkability
The text was updated successfully, but these errors were encountered: