Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EAC-34165 Entra compatability for SLO #6

Merged
merged 1 commit into from
Apr 22, 2024
Merged

EAC-34165 Entra compatability for SLO #6

merged 1 commit into from
Apr 22, 2024

Conversation

chet-wynn-cookieai
Copy link
Collaborator

Entra sends signature for SLO via query parameters. When it signs, it encodes the URL all lowercase. To validate Entra signed responses, we need to lowercase the URL encoding.

go test -count=1 ./...
?   	github.com/crewjam/saml/example	[no test files]
?   	github.com/crewjam/saml/example/idp	[no test files]
?   	github.com/crewjam/saml/example/trivial	[no test files]
?   	github.com/crewjam/saml/logger	[no test files]
?   	github.com/crewjam/saml/testsaml	[no test files]
ok  	github.com/crewjam/saml	2.390s
ok  	github.com/crewjam/saml/samlidp	0.889s
ok  	github.com/crewjam/saml/samlsp	0.319s
ok  	github.com/crewjam/saml/xmlenc	0.181s

@chet-wynn-cookieai chet-wynn-cookieai requested a review from a team April 20, 2024 14:38
@chet-wynn-cookieai chet-wynn-cookieai merged commit 2a7d918 into main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb-veza sb-veza sb-veza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chet-wynn-cookieai @sb-veza