Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fully qualified docker images #4905

Merged
merged 3 commits into from Mar 6, 2024
Merged

Fix fully qualified docker images #4905

merged 3 commits into from Mar 6, 2024

Conversation

GitBib
Copy link
Contributor

@GitBib GitBib commented Mar 6, 2024

Description

Fix Python Docker image version not being recognized after adding registry to image names

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Fix #4903

browniebroke
browniebroke approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@browniebroke browniebroke merged commit f39aff8 into cookiecutter:master Mar 6, 2024
14 checks passed
@GitBib GitBib deleted the fix_fully_qualified_docker_images branch March 6, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Python version in Docker.
2 participants
@GitBib @browniebroke