Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fully qualified docker images #4905

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fix fully qualified docker images #4905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e582e71
Fix Python (docker) Docker image version not being recognized after a…
GitBib Mar 6, 2024
f60138b
Fix Python (docs) Docker image version not being recognized after add…
GitBib Mar 6, 2024
4ac11b1
Fix Python (django) Docker image version not being recognized after a…
GitBib Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/compose/local/django/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM docker.io/python:3.11.8-slim-bookworm as python

# Python build stage
FROM docker.io/python as python-build-stage
FROM python as python-build-stage

ARG BUILD_ENVIRONMENT=local

Expand All @@ -22,7 +22,7 @@ RUN pip wheel --wheel-dir /usr/src/app/wheels \


# Python 'run' stage
FROM docker.io/python as python-run-stage
FROM python as python-run-stage

ARG BUILD_ENVIRONMENT=local
ARG APP_HOME=/app
Expand Down
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/compose/local/docs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM docker.io/python:3.11.8-slim-bookworm as python


# Python build stage
FROM docker.io/python as python-build-stage
FROM python as python-build-stage

ENV PYTHONDONTWRITEBYTECODE 1

Expand All @@ -26,7 +26,7 @@ RUN pip wheel --no-cache-dir --wheel-dir /usr/src/app/wheels \


# Python 'run' stage
FROM docker.io/python as python-run-stage
FROM python as python-run-stage

ARG BUILD_ENVIRONMENT
ENV PYTHONUNBUFFERED 1
Expand Down
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/compose/production/django/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN npm run build
FROM docker.io/python:3.11.8-slim-bookworm as python

# Python build stage
FROM docker.io/python as python-build-stage
FROM python as python-build-stage

ARG BUILD_ENVIRONMENT=production

Expand All @@ -48,7 +48,7 @@ RUN pip wheel --wheel-dir /usr/src/app/wheels \


# Python 'run' stage
FROM docker.io/python as python-run-stage
FROM python as python-run-stage

ARG BUILD_ENVIRONMENT=production
ARG APP_HOME=/app
Expand Down